You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Adam Fokken <ad...@gmail.com> on 2011/10/03 00:54:26 UTC
Review Request: HIVE-1399 - Nested UDAFs cause Hive Internal Error
(NullPointerException)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2146/
-----------------------------------------------------------
Review request for hive.
Summary
-------
HIVE-1399 - fix for null pointer with nested UDAFs
This addresses bug HIVE-1399.
https://issues.apache.org/jira/browse/HIVE-1399
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 2798eaa
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 0fd4eb9
ql/src/test/queries/clientnegative/udaf_not_supported1.q e69de29
ql/src/test/results/clientnegative/udaf_not_supported1.q.out e69de29
Diff: https://reviews.apache.org/r/2146/diff
Testing
-------
Thanks,
Adam
Re: Review Request: HIVE-1399 - Nested UDAFs cause Hive Internal Error
(NullPointerException)
Posted by John Sichi <js...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2146/#review2625
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
<https://reviews.apache.org/r/2146/#comment5933>
Need a better error message here since
(a) this validation rule applies to builtin aggregate function such as SUM also (so we should just refer to "aggregate functions" rather than UDAF's)
(b) this error message also shows up if you try to use an aggregate function in the WHERE clause (or anywhere other than SELECT/HAVING)
So either we need to discriminate the two contexts, or else come up with a wording that covers both without causing confusion.
- John
On 2011-10-02 22:54:26, Adam Fokken wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2146/
> -----------------------------------------------------------
>
> (Updated 2011-10-02 22:54:26)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> HIVE-1399 - fix for null pointer with nested UDAFs
>
>
> This addresses bug HIVE-1399.
> https://issues.apache.org/jira/browse/HIVE-1399
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 2798eaa
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 0fd4eb9
> ql/src/test/queries/clientnegative/udaf_not_supported1.q e69de29
> ql/src/test/results/clientnegative/udaf_not_supported1.q.out e69de29
>
> Diff: https://reviews.apache.org/r/2146/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam
>
>