You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/07/24 02:35:09 UTC
[GitHub] carbondata pull request #2543: [HOTFIX] Minor optimization for getBlockletNu...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2543
[HOTFIX] Minor optimization for getBlockletNumber to return integer
Change BlockletScannedResult.getBlockletNumber to return integer
- [X] Any interfaces changed?
No
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
No testcase is added, rerun existing test suites
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata parseint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2543.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2543
----
commit 44dbb6632b075cb869966dbb756c845818091fac
Author: Jacky Li <ja...@...>
Date: 2018-07-24T02:33:14Z
change getBlockletNumber to return integer
----
---
[GitHub] carbondata issue #2543: [HOTFIX] Minor optimization for getBlockletNumber to...
Posted by kevinjmh <gi...@git.apache.org>.
Github user kevinjmh commented on the issue:
https://github.com/apache/carbondata/pull/2543
LGTM
---
[GitHub] carbondata issue #2543: [HOTFIX] Minor optimization for getBlockletNumber to...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2543
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6183/
---
[GitHub] carbondata issue #2543: [HOTFIX] Minor optimization for getBlockletNumber to...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2543
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7423/
---
[GitHub] carbondata pull request #2543: [HOTFIX] Minor optimization for getBlockletNu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2543
---
[GitHub] carbondata issue #2543: [HOTFIX] Minor optimization for getBlockletNumber to...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2543
LGTM
---