You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/29 16:08:39 UTC

[GitHub] [incubator-eventmesh] horoc opened a new issue, #1458: [Enhancement] Prevent potential input resource leak

horoc opened a new issue, #1458:
URL: https://github.com/apache/incubator-eventmesh/issues/1458

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   There are many property-init methods that create an input stream and forget to close the stream after reading.
   
   <img width="919" alt="image" src="https://user-images.githubusercontent.com/63457588/193079959-897bc785-41d9-48be-b765-e4b54c32c5e8.png">
   
   I think we'd better close the file resource after reading. And since many of the property-load methods are almost the same, we can extract a common method to do the loading.
   
   ### Describe the solution you'd like
   
   call close method after using FileInputStream.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 closed issue #1458: [Enhancement] Prevent potential input resource leak

Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #1458: [Enhancement] Prevent potential input resource leak
URL: https://github.com/apache/incubator-eventmesh/issues/1458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org