You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/21 19:34:16 UTC

[GitHub] [apisix] jbampton commented on pull request #3624: feat: add pre-commit framework

jbampton commented on pull request #3624:
URL: https://github.com/apache/apisix/pull/3624#issuecomment-782912613


   All the hooks are listed here -> https://pre-commit.com/hooks.html
   
   So we can add even more checks.   There is even a check we could add to add licenses to files that don't have them.
   
   Some of the checks are commented out and can be added in future.
   
   I added a few more standard tests seen in the next image:
   
   <img width="890" alt="Screen Shot 2021-02-22 at 5 26 51 am" src="https://user-images.githubusercontent.com/418747/108636126-12f48880-74cf-11eb-856a-bdd1d2dc318d.png">
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org