You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by wa...@apache.org on 2022/07/28 14:13:03 UTC

[echarts] 03/03: test(vrt): fix changing value of select via js doesn't trigger `change` event.

This is an automated email from the ASF dual-hosted git repository.

wangzx pushed a commit to branch fix/symbol-emphasis-scale
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit 4ed662984e006d889436dec4e6432e5a2355cdce
Author: plainheart <yh...@all-my-life.cn>
AuthorDate: Thu Jul 28 22:09:38 2022 +0800

    test(vrt): fix changing value of select via js doesn't trigger `change` event.
---
 test/runTest/runtime/ActionPlayback.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/test/runTest/runtime/ActionPlayback.js b/test/runTest/runtime/ActionPlayback.js
index 6a41f4271..aa50caa67 100644
--- a/test/runTest/runtime/ActionPlayback.js
+++ b/test/runTest/runtime/ActionPlayback.js
@@ -186,7 +186,10 @@ export class ActionPlayback {
                 screenshotTaken = true;
                 break;
             case 'valuechange':
-                document.querySelector(op.selector).value = op.value;
+                const selector = document.querySelector(op.selector);
+                selector.value = op.value;
+                // changing value via js won't trigger `change` event, so trigger it manually
+                selector.dispatchEvent(new Event('change'));
                 break;
         }
 
@@ -213,4 +216,4 @@ export class ActionPlayback {
 
         return true;
     }
-};
\ No newline at end of file
+};


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org