You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@manifoldcf.apache.org by "Karl Wright (JIRA)" <ji...@apache.org> on 2016/08/03 11:21:20 UTC

[jira] [Commented] (CONNECTORS-1330) Organize LDAPAuthority Class

    [ https://issues.apache.org/jira/browse/CONNECTORS-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405750#comment-15405750 ] 

Karl Wright commented on CONNECTORS-1330:
-----------------------------------------

It's not clear to me that this patch offers much in the way of "organization".  It seems to be a minor random refactoring that isn't really very much improved over what was present before.  For example, introducing the enum doesn't seem to help anything that I can see except complexity.



> Organize LDAPAuthority Class
> ----------------------------
>
>                 Key: CONNECTORS-1330
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1330
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: LDAP authority
>    Affects Versions: ManifoldCF 2.4
>            Reporter: Furkan KAMACI
>            Priority: Minor
>             Fix For: ManifoldCF 2.5
>
>         Attachments: CONNECTORS-1330.patch
>
>
> LDAPAuthority class is not readable and should be organized for different server protocols.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)