You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by GitBox <gi...@apache.org> on 2023/01/12 21:30:51 UTC
[GitHub] [ws-xmlschema] opwvhk opened a new pull request, #3: Fix XMLSCHEMA-64
opwvhk opened a new pull request, #3:
URL: https://github.com/apache/ws-xmlschema/pull/3
The `visitedElements` set prevents infinite recursion, but assumes all elements have unique names. But this is only true for top-level names. By stopping recursion only at toplevel elements/types, different subelements with identical names are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-xmlschema] dkulp merged pull request #3: Fix XMLSCHEMA-64
Posted by "dkulp (via GitHub)" <gi...@apache.org>.
dkulp merged PR #3:
URL: https://github.com/apache/ws-xmlschema/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-xmlschema] hannsl commented on pull request #3: Fix XMLSCHEMA-64
Posted by "hannsl (via GitHub)" <gi...@apache.org>.
hannsl commented on PR #3:
URL: https://github.com/apache/ws-xmlschema/pull/3#issuecomment-1466460421
Hi, Also running into this problem due to the check on element name rather than type. Would be great if this we could get this fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-xmlschema] hannsl commented on pull request #3: Fix XMLSCHEMA-64
Posted by "hannsl (via GitHub)" <gi...@apache.org>.
hannsl commented on PR #3:
URL: https://github.com/apache/ws-xmlschema/pull/3#issuecomment-1469915565
Hi, been thinking about this a little bit more. The best approach would be to modify the Schema Walker to accept a configurable predicate on XmlSchemaElement for doing the previously visited check. That way the existing behavior can be preserved while accommodating more specific requirements. For example, I would prefer to only include top level complex types in my previously visited list (I'm not concerned about infinite recursion).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-xmlschema] opwvhk commented on pull request #3: Fix XMLSCHEMA-64
Posted by "opwvhk (via GitHub)" <gi...@apache.org>.
opwvhk commented on PR #3:
URL: https://github.com/apache/ws-xmlschema/pull/3#issuecomment-1467630634
Hi,
Given that I'm not the only one to run into this problem, is there a
comitter that feels comfortable reviewing the PR?
The PR is here: https://github.com/apache/ws-xmlschema/pull/3
Kind regards,
Oscar
On Mon, 13 Mar 2023 at 17:18, hannsl ***@***.***> wrote:
> Hi, Also running into this problem due to the check on element name rather
> than type. Would be great if this we could get this fixed.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/ws-xmlschema/pull/3#issuecomment-1466460421>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAGI5UAVP3OIIB5PIRR2A5TW35CFTANCNFSM6AAAAAATZWYZWI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
✉️ Oscar Westra van Holthe - Kind ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org