You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2024/02/02 06:16:00 UTC

[jira] [Updated] (HDDS-10277) Remove unnecessary fail() from tests

     [ https://issues.apache.org/jira/browse/HDDS-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Attila Doroszlai updated HDDS-10277:
------------------------------------
    Description: 
{code}
try {
  <some action>
} catch (...) {
  fail()
}
{code}

{{try-catch-fail}} can be removed if there are other assertions in the test case.

{{throws Exception}} may need to be added to the signature.  If so, please also remove {{public}} visibility modifier, if present, from the method being changed.  (JUnit4 needed it, JUnit5 does not.)

  was:
{code}
try {
  <some action>
} catch (...) {
  fail()
}
{code}

{{try-catch-fail}} can be removed if there are other assertions in the test case.

{{throws Exception}} may need to be added to the signature.


> Remove unnecessary fail() from tests
> ------------------------------------
>
>                 Key: HDDS-10277
>                 URL: https://issues.apache.org/jira/browse/HDDS-10277
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Attila Doroszlai
>            Priority: Major
>
> {code}
> try {
>   <some action>
> } catch (...) {
>   fail()
> }
> {code}
> {{try-catch-fail}} can be removed if there are other assertions in the test case.
> {{throws Exception}} may need to be added to the signature.  If so, please also remove {{public}} visibility modifier, if present, from the method being changed.  (JUnit4 needed it, JUnit5 does not.)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org