You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/09/30 10:48:52 UTC
[GitHub] [systemds] ilovemesomeramen opened a new pull request #1405: [SYSTEMDS-2972] Transformable Interface and merged Code Paths for multi- and singlethreaded feature transformations
ilovemesomeramen opened a new pull request #1405:
URL: https://github.com/apache/systemds/pull/1405
This PR introduces the Transformable Interface which defines the needed functions for the Encoders. It is implemented by the `MatrixBlock` and `FrameBlock`. Due to the Interface, a lot of redundant code was removed and a single code path for Multi- and Singlethreaded operations was established, this makes the code a lot easier to navigate and read.
There is still redundant code in form of the SparseApply Tasks in each encoder, they can be removed in the future but at the moment they serve the purpose of easier debugging.
Furthermore, the handling of missing values was reworked for all encoders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab closed pull request #1405: [SYSTEMDS-2972] Transformable Interface and merged Code Paths for multi- and singlethreaded feature transformations
Posted by GitBox <gi...@apache.org>.
phaniarnab closed pull request #1405:
URL: https://github.com/apache/systemds/pull/1405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1405: [SYSTEMDS-2972] Transformable Interface and merged Code Paths for multi- and singlethreaded feature transformations
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #1405:
URL: https://github.com/apache/systemds/pull/1405#issuecomment-949355989
Thanks for the patch @ilovemesomeramen. I fixed a bug and a few syntax issues before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org