You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/17 11:14:57 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Pearl1594 opened a new pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331
## Description
Change upgrade path for image store table
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
Test Output:
Before migrate:
```
MariaDB [cloud]> select * from volume_store_ref\G
*************************** 1. row ***************************
id: 8
store_id: 2
volume_id: 3
zone_id: 0
created: 2020-09-17 10:49:23
last_updated: NULL
job_id: NULL
download_pct: 0
size: 52428800
physical_size: 0
download_state: NULL
checksum: NULL
error_str: NULL
local_path: NULL
install_path: volumes/2/3/365df8ed-b414-4311-af46-82043ee056af.qcow2
url: NULL
download_url: NULL
state: Ready
...
*************************** 5. row ***************************
id: 22
store_id: 2
template_id: 202
created: 2020-09-17 10:49:26
last_updated: NULL
job_id: NULL
download_pct: 100
size: 52428800
store_role: Image
physical_size: 43646976
download_state: DOWNLOADED
error_str: NULL
local_path: NULL
install_path: template/tmpl/2/202/6c3ec8aa-77fb-3cac-a74e-70f715361895.qcow2
url: NULL
state: Ready
....
MariaDB [cloud]> select * from snapshot_store_ref\G
************************** 2. row ***************************
id: 8
store_id: 2
snapshot_id: 1
created: 2020-09-17 10:49:23
last_updated: NULL
job_id: NULL
store_role: Image
size: 52428800
physical_size: 43646976
parent_snapshot_id: 0
install_path: snapshots/2/3/1fae4aa3-270e-490a-9592-3fc3cc40b35a
state: Ready
update_count: 2
ref_cnt: 0
updated: 2020-09-17 10:49:29
volume_id: 3
```
After migration:
```
MariaDB [cloud]> select * from volume_store_ref\G
*************************** 1. row ***************************
id: 9
store_id: 1
volume_id: 3
zone_id: 0
created: 2020-09-17 10:53:44
last_updated: NULL
job_id: NULL
download_pct: 0
size: 52428800
physical_size: 0
download_state: NULL
checksum: NULL
error_str: NULL
local_path: NULL
install_path: volumes/2/3/365df8ed-b414-4311-af46-82043ee056af.qcow2
url: NULL
download_url: NULL
state: Ready
MariaDB [cloud]> select * from template_store_ref\G
*************************** 6. row ***************************
id: 25
store_id: 1
template_id: 202
created: 2020-09-17 10:53:51
last_updated: NULL
job_id: NULL
download_pct: 100
size: 52428800
store_role: Image
physical_size: 43646976
download_state: DOWNLOADED
error_str: NULL
local_path: NULL
install_path: template/tmpl/2/202/6c3ec8aa-77fb-3cac-a74e-70f715361895.qcow2
url: NULL
state: Ready
MariaDB [cloud]> select * from snapshot_store_ref\G
*************************** 2. row ***************************
id: 9
store_id: 1
snapshot_id: 1
created: 2020-09-17 10:53:44
last_updated: NULL
job_id: NULL
store_role: Image
size: 52428800
physical_size: 43646976
parent_snapshot_id: 0
install_path: snapshots/2/3/1fae4aa3-270e-490a-9592-3fc3cc40b35a
state: Ready
update_count: 2
ref_cnt: 0
updated: 2020-09-17 10:53:51
volume_id: 3
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694751843
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2038
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694180781
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694268215
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-695167812
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694617376
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-695167875
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694669594
<b>Trillian test result (tid-2775)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53969 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4331-t2775-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 410.05 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3826.54 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 97.70 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#discussion_r490777365
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##########
@@ -1049,8 +1049,11 @@ protected Answer execute(CopyCommand cmd) {
DataTO destData = cmd.getDestTO();
DataStoreTO srcDataStore = srcData.getDataStore();
DataStoreTO destDataStore = destData.getDataStore();
-
- if (DataStoreRole.Image == srcDataStore.getRole() && DataStoreRole.Image == destDataStore.getRole()) {
+ if (DataStoreRole.Image == srcDataStore.getRole() && DataStoreRole.Image == destDataStore.getRole() &&
+ srcDataStore instanceof NfsTO && destDataStore instanceof NfsTO &&
+ ((srcData.getObjectType() == DataObjectType.TEMPLATE && destData.getObjectType() == DataObjectType.TEMPLATE) ||
+ (srcData.getObjectType() == DataObjectType.SNAPSHOT && destData.getObjectType() == DataObjectType.SNAPSHOT) ||
+ (srcData.getObjectType() == DataObjectType.VOLUME && destData.getObjectType() == DataObjectType.VOLUME))) {
Review comment:
@DaanHoogland extracted the conditional
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694164192
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694752456
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-695810481
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-695810415
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694712489
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#discussion_r490762192
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##########
@@ -1049,8 +1049,11 @@ protected Answer execute(CopyCommand cmd) {
DataTO destData = cmd.getDestTO();
DataStoreTO srcDataStore = srcData.getDataStore();
DataStoreTO destDataStore = destData.getDataStore();
-
- if (DataStoreRole.Image == srcDataStore.getRole() && DataStoreRole.Image == destDataStore.getRole()) {
+ if (DataStoreRole.Image == srcDataStore.getRole() && DataStoreRole.Image == destDataStore.getRole() &&
+ srcDataStore instanceof NfsTO && destDataStore instanceof NfsTO &&
+ ((srcData.getObjectType() == DataObjectType.TEMPLATE && destData.getObjectType() == DataObjectType.TEMPLATE) ||
+ (srcData.getObjectType() == DataObjectType.SNAPSHOT && destData.getObjectType() == DataObjectType.SNAPSHOT) ||
+ (srcData.getObjectType() == DataObjectType.VOLUME && destData.getObjectType() == DataObjectType.VOLUME))) {
Review comment:
please put this condition in a boolean method with a good descriptive name.
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql
##########
@@ -53,33 +53,6 @@ ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_offering_id` bigint unsigne
ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_external_id` varchar(255) DEFAULT NULL COMMENT 'ID of external backup job or container if any';
ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_volumes` text DEFAULT NULL COMMENT 'details of backedup volumes';
-ALTER TABLE `cloud`.`image_store` ADD COLUMN `readonly` boolean DEFAULT false COMMENT 'defines status of image store';
Review comment:
why is this moved to another upgrade script? it makes it harder to compare and would imply it will not be needed/used in propriatory 4.13 releases anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-695810415
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694729474
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694617186
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 removed a comment on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 removed a comment on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694179332
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694181296
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694725669
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694728817
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694725473
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694752129
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694164782
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-696498403
Manually verified, no regressions seen. The tests finished at backend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694268810
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#discussion_r490764722
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql
##########
@@ -53,33 +53,6 @@ ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_offering_id` bigint unsigne
ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_external_id` varchar(255) DEFAULT NULL COMMENT 'ID of external backup job or container if any';
ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_volumes` text DEFAULT NULL COMMENT 'details of backedup volumes';
-ALTER TABLE `cloud`.`image_store` ADD COLUMN `readonly` boolean DEFAULT false COMMENT 'defines status of image store';
Review comment:
@DaanHoogland This is related to PR#4053 which merged recently to master where the schema changes were made in old schema file.
https://github.com/apache/cloudstack/pull/4053/files#r490066335
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-695132931
<b>Trillian test result (tid-2776)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 74089 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4331-t2776-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 80 look OK, 5 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1807.72 | test_kubernetes_supported_versions.py
test_create_pvlan_network | `Error` | 0.04 | test_pvlan.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 149.38 | test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 451.74 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 557.67 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3885.46 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 103.04 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694179332
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-696498403
Manually verified, no regressions seen. The tests finished at backend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-695810481
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4331: change upgrade path to 4.14 (from 4.13) and intensify check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4331:
URL: https://github.com/apache/cloudstack/pull/4331#issuecomment-694178986
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org