[GitHub] nastra commented on issue #1067: TINKERPOP-2164: Reduce chance of hash collisions in Bytecode and its inner classes

[GitBox <gi...@apache.org>]

nastra commented on issue #1067: TINKERPOP-2164: Reduce chance of hash collisions in Bytecode and its inner classes
URL: https://github.com/apache/tinkerpop/pull/1067#issuecomment-465965675
 
 
   @jorgebay force pushed two tests. 
   Ideally we should be using e.g. guava's `EqualsTester` to make sure equals/hashCode are properly implemented. The problem however is that Java's equals/hashCode contract allows hash collisions if two objects are equal but that doesn't mean that one should produce hash collisions as otherwise perf will be negatively affected when using those objects in data structures relying on hashCode

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services