You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Lefty Leverenz <le...@gmail.com> on 2015/12/01 09:47:06 UTC
Re: Review Request 40315: HIVE-12341 LLAP security
> On Nov. 30, 2015, 7:49 a.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2377-2378
> > <https://reviews.apache.org/r/40315/diff/6/?file=1147130#file1147130line2377>
> >
> > Should this have a TimeValidator (like the next two Spark parameters, lines 2372-2376)?
> >
> > Also, the default is 14 * 24 * 3600 but the comment says DelegationTokenManager default is 1 week instead of 2 weeks, so is DelegationTokenManager something different from this parameter?
>
> Sergey Shelukhin wrote:
> Yes, that is the hadoop delegation token manager. This is a comment for the background of how the ballpark for the default value was chosen.
Okay, thanks Sergey.
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40315/#review108296
-----------------------------------------------------------
On Nov. 30, 2015, 7:50 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40315/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 7:50 p.m.)
>
>
> Review request for hive, Gopal V and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9e805bd
> llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapIoProxy.java 4c31e32
> llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java PRE-CREATION
> llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenIdentifier.java PRE-CREATION
> llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/LlapDaemonProtocolBlockingPB.java 5ad2344
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/LlapManagementProtocolBlockingPB.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolClientImpl.java 4b13277
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolServerImpl.java 784c631
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapManagementProtocolClientImpl.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/protocol/LlapTaskUmbilicalProtocol.java fae7654
> llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapDaemonPolicyProvider.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapServerSecurityInfo.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapTokenSelector.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapUmbilicalPolicyProvider.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
> llap-server/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo PRE-CREATION
> llap-server/src/main/resources/META-INF/services/org.apache.hadoop.security.token.TokenRenewer PRE-CREATION
> llap-server/src/protobuf/LlapDaemonProtocol.proto 0ba6acf
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a210b95
> ql/src/java/org/apache/hadoop/hive/ql/exec/GlobalWorkMapFactory.java 59ee347
> ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheFactory.java 3d9771a
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java 914b4e7
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java efcf88c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 07f26be
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 3feab1a
> serde/src/java/org/apache/hadoop/hive/serde2/AbstractSerDe.java 9269ff4
>
> Diff: https://reviews.apache.org/r/40315/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>