You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "tqchen (via GitHub)" <gi...@apache.org> on 2023/03/19 02:09:28 UTC

[GitHub] [tvm] tqchen opened a new pull request, #14330: [CODEGEN][METAL] Fix ramp codegen

tqchen opened a new pull request, #14330:
URL: https://github.com/apache/tvm/pull/14330

   Fix ramp node codegen for the metal backend.
   The default C codegen can cause problem in
   vector indices assignment.
   
   Confirmed on apple M2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on pull request #14330: [CODEGEN][METAL] Fix ramp codegen

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14330:
URL: https://github.com/apache/tvm/pull/14330#issuecomment-1475129836

   Agree with @echuraev that we might need a unittest. @tqchen @MasterJH5574 would you like to follow up with a new PR? Thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #14330: [CODEGEN][METAL] Fix ramp codegen

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #14330:
URL: https://github.com/apache/tvm/pull/14330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14330: [CODEGEN][METAL] Fix ramp codegen

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14330:
URL: https://github.com/apache/tvm/pull/14330#issuecomment-1475073215

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @echuraev <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #14330: [CODEGEN][METAL] Fix ramp codegen

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14330:
URL: https://github.com/apache/tvm/pull/14330#issuecomment-1475232839

   Thanks @echuraev . we will send in a test in a followup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #14330: [CODEGEN][METAL] Fix ramp codegen

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14330:
URL: https://github.com/apache/tvm/pull/14330#issuecomment-1475251952

   https://github.com/apache/tvm/pull/14331


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #14330: [CODEGEN][METAL] Fix ramp codegen

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14330:
URL: https://github.com/apache/tvm/pull/14330#issuecomment-1475075339

   currently ci do not support metal, confirmed on apple M2 for some cases that works on cuda, 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org