You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/13 07:37:18 UTC
[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in
pull request #3731: Support scaling for shardingsphere
KomachiSion commented on a change in pull request #3731: Support scaling for shardingsphere
URL: https://github.com/apache/incubator-shardingsphere/pull/3731#discussion_r357515810
##########
File path: sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java
##########
@@ -108,6 +108,7 @@ private void getEstimatedRows() {
}
private void instanceSyncRunner() {
+ syncConfiguration.getReaderConfiguration().setTableNameMap(syncConfiguration.getTableNameMap());
Review comment:
I think we can move the logic out to Controller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services