You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/08/27 20:34:31 UTC
Review Request 71376: Avoid potential for race in Master::apply.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71376/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Meng Zhu.
Repository: mesos
Description
-------
Previously, the future could be satisfied to the caller while
the dispatch back into the master for _apply is not fired (e.g.
if the thread running the allocator gets stuck). This could lead
to strange behavior and it's better to just avoid this race.
Diffs
-----
src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b
Diff: https://reviews.apache.org/r/71376/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71376: Avoid potential for race in Master::apply.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71376/#review217473
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71376]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 27, 2019, 1:34 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71376/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2019, 1:34 p.m.)
>
>
> Review request for mesos, Greg Mann and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the future could be satisfied to the caller while
> the dispatch back into the master for _apply is not fired (e.g.
> if the thread running the allocator gets stuck). This could lead
> to strange behavior and it's better to just avoid this race.
>
>
> Diffs
> -----
>
> src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b
>
>
> Diff: https://reviews.apache.org/r/71376/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71376: Avoid potential for race in Master::apply.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71376/#review217506
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Aug. 27, 2019, 1:34 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71376/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2019, 1:34 p.m.)
>
>
> Review request for mesos, Greg Mann and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the future could be satisfied to the caller while
> the dispatch back into the master for _apply is not fired (e.g.
> if the thread running the allocator gets stuck). This could lead
> to strange behavior and it's better to just avoid this race.
>
>
> Diffs
> -----
>
> src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b
>
>
> Diff: https://reviews.apache.org/r/71376/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>