You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Weijun-H (via GitHub)" <gi...@apache.org> on 2023/03/08 21:32:03 UTC
[GitHub] [arrow-datafusion] Weijun-H opened a new pull request, #5517: fix: cast literal to timestamp
Weijun-H opened a new pull request, #5517:
URL: https://github.com/apache/arrow-datafusion/pull/5517
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5507
# Rationale for this change
When converting between different timestamps, reduce the precision by truncating excess digits.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5517: fix: cast literal to timestamp
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5517:
URL: https://github.com/apache/arrow-datafusion/pull/5517#issuecomment-1466409973
Benchmark runs are scheduled for baseline = 9464bf2eb593ce239acf3823c5ecdc6760b15679 and contender = 1f8ede5701c5013500fe01ec46903fe31de92785. 1f8ede5701c5013500fe01ec46903fe31de92785 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e421b2cf9f604e40bd80f53d22a00c74...63788db9eafd41a1a966c3cf30c88828/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/77bc05c05ea44641891455bd6313e64e...e74242aa93d540f9b0155e54677759e3/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/31c259a23d8941f987dee47dfb8f3064...e600d8afb9884414b72c24c4acb02c0d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ed1d5e895ff448b5931f221009c55f4d...3a993f3193074b3b938e2acd5d8faae1/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5517: fix: cast literal to timestamp
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5517:
URL: https://github.com/apache/arrow-datafusion/pull/5517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5517: fix: cast literal to timestamp
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5517:
URL: https://github.com/apache/arrow-datafusion/pull/5517#discussion_r1131237011
##########
datafusion/optimizer/src/unwrap_cast_in_comparison.rs:
##########
@@ -428,6 +452,36 @@ fn try_cast_literal_to_type(
}
}
+/// Cast a timestamp value from one unit to another
+fn cast_between_timestamp(from: DataType, to: DataType, value: i128) -> Option<i64> {
Review Comment:
I think this has problematic overflow behaviour, I wonder if we can determine the scale factor and multiply or divide by this instead? This is what arrow-cast does - https://github.com/apache/arrow-rs/blob/master/arrow-cast/src/cast.rs#L1671
Currently I think converting `i64::MAX / 1_000` to milliseconds from seconds will silently overflow, when in reality it shouldn't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5517: fix: cast literal to timestamp
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #5517:
URL: https://github.com/apache/arrow-datafusion/pull/5517#discussion_r1130228489
##########
datafusion/optimizer/src/unwrap_cast_in_comparison.rs:
##########
@@ -1070,4 +1119,19 @@ mod tests {
}
}
}
+
+ #[test]
+ fn test_try_cast_literal_to_timestamp() {
Review Comment:
please add more tests between timestamps
##########
datafusion/optimizer/src/unwrap_cast_in_comparison.rs:
##########
@@ -428,6 +452,31 @@ fn try_cast_literal_to_type(
}
}
+/// Cast a timestamp value from one unit to another
+fn cast_between_timestamp(from: DataType, to: DataType, value: i128) -> Option<i64> {
+ let seconds = match from {
Review Comment:
I think it can be improved. if the cast Second to Second, then the code will do unneccessary mul by 1m and then div by 1m
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5517: fix: cast literal to timestamp
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5517:
URL: https://github.com/apache/arrow-datafusion/pull/5517#discussion_r1134194707
##########
datafusion/optimizer/src/unwrap_cast_in_comparison.rs:
##########
@@ -1070,4 +1118,162 @@ mod tests {
}
}
}
+
+ #[test]
+ fn test_try_cast_literal_to_timestamp() {
+ // same timestamp
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampNanosecond(Some(123456), None),
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampNanosecond(Some(123456), None)
+ );
+
+ // TimestampNanosecond to TimestampMicrosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampNanosecond(Some(123456), None),
+ &DataType::Timestamp(TimeUnit::Microsecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampMicrosecond(Some(123), None)
+ );
+
+ // TimestampNanosecond to TimestampMillisecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampNanosecond(Some(123456), None),
+ &DataType::Timestamp(TimeUnit::Millisecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(new_scalar, ScalarValue::TimestampMillisecond(Some(0), None));
+
+ // TimestampNanosecond to TimestampSecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampNanosecond(Some(123456), None),
+ &DataType::Timestamp(TimeUnit::Second, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(new_scalar, ScalarValue::TimestampSecond(Some(0), None));
+
+ // TimestampMicrosecond to TimestampNanosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMicrosecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampNanosecond(Some(123000), None)
+ );
+
+ // TimestampMicrosecond to TimestampMillisecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMicrosecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Millisecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(new_scalar, ScalarValue::TimestampMillisecond(Some(0), None));
+
+ // TimestampMicrosecond to TimestampSecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMicrosecond(Some(123456789), None),
+ &DataType::Timestamp(TimeUnit::Second, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(new_scalar, ScalarValue::TimestampSecond(Some(123), None));
+
+ // TimestampMillisecond to TimestampNanosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMillisecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampNanosecond(Some(123000000), None)
+ );
+
+ // TimestampMillisecond to TimestampMicrosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMillisecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Microsecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampMicrosecond(Some(123000), None)
+ );
+ // TimestampMillisecond to TimestampSecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMillisecond(Some(123456789), None),
+ &DataType::Timestamp(TimeUnit::Second, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(new_scalar, ScalarValue::TimestampSecond(Some(123456), None));
+
+ // TimestampSecond to TimestampNanosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampSecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampNanosecond(Some(123000000000), None)
+ );
+
+ // TimestampSecond to TimestampMicrosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampSecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Microsecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampMicrosecond(Some(123000000), None)
+ );
+
+ // TimestampSecond to TimestampMillisecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampSecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Millisecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampMillisecond(Some(123000), None)
+ );
+
+ // overflow
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampSecond(Some(i64::MAX), None),
+ &DataType::Timestamp(TimeUnit::Millisecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(new_scalar, ScalarValue::TimestampMillisecond(None, None));
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org