You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/03/10 15:24:35 UTC

Re: Review Request 18594: Added liveProcesses to process tree abstraction.


> On Feb. 28, 2014, 6:43 p.m., Ben Mahler wrote:
> > Did you still want this now that r/18604/ is submitted?
> 
> Niklas Nielsen wrote:
>     Till has been using them in a reworked version of signal escalation in PluggableContainerizer::destroy(). We wanted to give the external program a chance to clean up before sigkilling. He is currently working on it; I'll drop them if he decides to go with a different approach :)

This indeed has been rather valuable for the PluggableContainerizer, hence it would be great if we got this committed. In my tests, this approach worked flawlessly. 


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18594/#review35813
-----------------------------------------------------------


On Feb. 28, 2014, 12:55 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18594/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 12:55 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> liveProcesses() returns a count of the existing processes in a process tree. This is used by up coming signal escalation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 26f4fbe 
> 
> Diff: https://reviews.apache.org/r/18594/diff/
> 
> 
> Testing
> -------
> 
> Functional testing with signal escalation code and make check.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>