[GitHub] thrift pull request #1419: Thrift 4393 plugin renumber for stable output acr...

[chetmurthy <gi...@git.apache.org>]

GitHub user chetmurthy opened a pull request:

    https://github.com/apache/thrift/pull/1419

    Thrift 4393 plugin renumber for stable output across runs

    added a unique ID generator in plugin_output.cc, so GeneratorInput can be uniquely numbered.  Added a unit-test that fails before and succeeds after.  Fixed-up conversion_test.cc so that global caches in both plugin & plugin_output get cleared before each test-case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chetmurthy/thrift THRIFT-4393-plugin-renumber-for-stable-output-across-runs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1419.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1419
    
----
commit e0240e874b991e4848eb727b9805fa62146e3f83
Author: Chet Murthy <ch...@gmail.com>
Date:   2017-11-27T05:42:26Z

    a unit-test to check that repeated runs of the plugin produce identical output
    
    It fails right now; next commit will fix.

commit 2bcc79b75ecc5b144e92de2b343ad2de01372266
Author: Chet Murthy <ch...@gmail.com>
Date:   2017-11-27T20:54:19Z

    THRIFT-4393 renumber GeneratorInput t_{type,etc...}_id
    
    So that GeneratorInput is determinsitic, hence the same across multiple
    runs.

commit 8caed0646ea6f4f46d3ad6a4415dbb63c5e21b6f
Author: Chet Murthy <ch...@gmail.com>
Date:   2017-11-27T20:59:22Z

    added comment

----


---

[GitHub] thrift pull request #1419: Thrift 4393 plugin renumber for stable output acr...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1419


---