You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/28 04:11:27 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
AngersZhuuuu opened a new pull request #31678:
URL: https://github.com/apache/spark/pull/31678
### What changes were proposed in this pull request?
Fix typo if `spark. launcher .childConnectionTimeout`
### Why are the changes needed?
Fix configuration type
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31678:
URL: https://github.com/apache/spark/pull/31678#issuecomment-787404826
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40130/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31678:
URL: https://github.com/apache/spark/pull/31678#discussion_r584245115
##########
File path: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java
##########
@@ -93,7 +93,7 @@
* Maximum time (in ms) to wait for a child process to connect back to the launcher server
* when using @link{#start()}.
*/
- public static final String CHILD_CONNECTION_TIMEOUT = "spark.launcher.childConectionTimeout";
+ public static final String CHILD_CONNECTION_TIMEOUT = "spark.launcher.childConnectionTimeout";
Review comment:
link: https://github.com/apache/spark/pull/30679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31678:
URL: https://github.com/apache/spark/pull/31678#issuecomment-787341445
@HyukjinKwon @dongjoon-hyun @maropu A configuration typo, I think it's wroth to raise a minor PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31678:
URL: https://github.com/apache/spark/pull/31678#issuecomment-787404826
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40130/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu closed pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu closed pull request #31678:
URL: https://github.com/apache/spark/pull/31678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31678:
URL: https://github.com/apache/spark/pull/31678#issuecomment-787411245
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135549/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #31678:
URL: https://github.com/apache/spark/pull/31678#discussion_r584245317
##########
File path: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java
##########
@@ -93,7 +93,7 @@
* Maximum time (in ms) to wait for a child process to connect back to the launcher server
* when using @link{#start()}.
*/
- public static final String CHILD_CONNECTION_TIMEOUT = "spark.launcher.childConectionTimeout";
+ public static final String CHILD_CONNECTION_TIMEOUT = "spark.launcher.childConnectionTimeout";
Review comment:
Hmmmm OK I will close this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31678:
URL: https://github.com/apache/spark/pull/31678#issuecomment-787392067
**[Test build #135549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135549/testReport)** for PR 31678 at commit [`9f6425a`](https://github.com/apache/spark/commit/9f6425a0c9d32297d70e76c4527719ac84e66180).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31678:
URL: https://github.com/apache/spark/pull/31678#issuecomment-787411245
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135549/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31678:
URL: https://github.com/apache/spark/pull/31678#issuecomment-787392067
**[Test build #135549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135549/testReport)** for PR 31678 at commit [`9f6425a`](https://github.com/apache/spark/commit/9f6425a0c9d32297d70e76c4527719ac84e66180).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31678:
URL: https://github.com/apache/spark/pull/31678#issuecomment-787405885
**[Test build #135549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135549/testReport)** for PR 31678 at commit [`9f6425a`](https://github.com/apache/spark/commit/9f6425a0c9d32297d70e76c4527719ac84e66180).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31678: [SPARK-34566][LAUNCHER] Fix configuration typo of spark. launcher.childConnectionTimeout
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31678:
URL: https://github.com/apache/spark/pull/31678#discussion_r584245062
##########
File path: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java
##########
@@ -93,7 +93,7 @@
* Maximum time (in ms) to wait for a child process to connect back to the launcher server
* when using @link{#start()}.
*/
- public static final String CHILD_CONNECTION_TIMEOUT = "spark.launcher.childConectionTimeout";
+ public static final String CHILD_CONNECTION_TIMEOUT = "spark.launcher.childConnectionTimeout";
Review comment:
Please see: https://github.com/apache/spark/pull/30323#discussion_r521449342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org