You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/06/25 14:16:21 UTC
[GitHub] [jackrabbit-filevault] DominikSuess opened a new pull request #152: JCRVLT-542 - adding checks for importmode of filterPathSet along with…
DominikSuess opened a new pull request #152:
URL: https://github.com/apache/jackrabbit-filevault/pull/152
… corresponding IT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-filevault] kwin commented on pull request #152: JCRVLT-542 - adding checks for importmode of filterPathSet along with…
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #152:
URL: https://github.com/apache/jackrabbit-filevault/pull/152#issuecomment-869398677
Superseded by #153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-filevault] kwin commented on pull request #152: JCRVLT-542 - adding checks for importmode of filterPathSet along with…
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #152:
URL: https://github.com/apache/jackrabbit-filevault/pull/152#issuecomment-868553291
@DominikSuess Thanks for the PR. IIUC this is a regression, so I wonder which commit broke this. IMHO there was never a check for import mode in that handler, so even before https://github.com/apache/jackrabbit-filevault/commit/5f3b1d363da7bcf3c285a0bdbb394254ca3e57d1#diff-8d660cbc935be10303ebfd498eb1574cbba07f3ae8e565f470762b2e6f97b512 it was probably behaving like that. Do you have further insights since when this do no longer work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-filevault] kwin closed pull request #152: JCRVLT-542 - adding checks for importmode of filterPathSet along with…
Posted by GitBox <gi...@apache.org>.
kwin closed pull request #152:
URL: https://github.com/apache/jackrabbit-filevault/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-filevault] kwin commented on pull request #152: JCRVLT-542 - adding checks for importmode of filterPathSet along with…
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #152:
URL: https://github.com/apache/jackrabbit-filevault/pull/152#issuecomment-868607594
Ok, regression identified in https://issues.apache.org/jira/browse/JCRVLT-542?focusedCommentId=17369527&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17369527. I came up with a slightly different fix because even mode UPDATE should never modify the primary type in https://github.com/apache/jackrabbit-filevault/pull/153. @DominikSuess Please have a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org