You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/06 12:38:53 UTC
[GitHub] [flink] hequn8128 commented on a change in pull request #11020:
[FLINK-15913][python] Add Python TableFunction Runner and Operator in old
planner
hequn8128 commented on a change in pull request #11020: [FLINK-15913][python] Add Python TableFunction Runner and Operator in old planner
URL: https://github.com/apache/flink/pull/11020#discussion_r375778304
##########
File path: flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/PythonTypeUtils.java
##########
@@ -90,6 +91,39 @@ public static TypeSerializer toBlinkTypeSerializer(LogicalType logicalType) {
return logicalType.accept(new LogicalTypeToProtoTypeConverter());
}
+ public static TypeSerializer toFlinkTableTypeSerializer(LogicalType logicalType) {
Review comment:
Since this method is only used by TableFunction, I'd like not to add this method in the class. How about add it in `PythonTableFunctionRunner`.
Same for `toTableProtoType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services