You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by Hanks10100 <gi...@git.apache.org> on 2017/07/28 05:38:32 UTC
[GitHub] incubator-weex pull request #550: [jsfm] Fix potential memory leak in callba...
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex/pull/550
[jsfm] Fix potential memory leak in callbacks
+ [x] pass instance id to callback manager.
+ [x] Destroy `taskCenter` when destory the `document`.
+ [x] Change the type of `callbacks` from array to object.
+ [x] Support to return values in `fireEvent`.
+ [x] Support to send `options` as last argument in `callNativeModule` and `callNativeComponent`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hanks10100/incubator-weex jsfm-0.21
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/550.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #550
----
commit 18c79244791fcdee62b4924647ed5c488e18ebde
Author: Hanks <zh...@gmail.com>
Date: 2017-06-21T08:54:50Z
* [jsfm] support send options in task center
commit 769167a7ad5acce8354478c3033ba2396906a8a2
Author: Hanks <zh...@gmail.com>
Date: 2017-07-26T08:01:47Z
Merge branch 'send-options' into jsfm-0.21
commit acd5814a8e64f6cc1dff52b9c5333867d5107570
Author: Hanks <zh...@gmail.com>
Date: 2017-07-26T08:03:57Z
* [jsfm] change callbacks from array to object
commit e57f8245fb074b681bf5f041cf92ff8d92bb61e9
Author: Hanks <zh...@gmail.com>
Date: 2017-07-26T08:07:58Z
* [jsfm] destroy taskCenter when destory the document
commit 8130b5c599bbf58236e1668944ad593651a3a174
Author: Hanks <zh...@gmail.com>
Date: 2017-07-26T08:09:00Z
* [jsfm] pass instance id to callback manager
commit 523abfeefa366d796bd16f678c19501c1374bbb8
Author: Hanks <zh...@gmail.com>
Date: 2017-07-26T08:23:22Z
* [jsfm] support return values in fireEvent
commit 8540aa4f35cb2fa27259cfa4646f09b23c407e53
Author: Hanks <zh...@gmail.com>
Date: 2017-07-26T08:27:28Z
* [jsfm] upgrade weex-rax-framework and weex-vue-framework
commit ac53dc8c19e03de67d93658f9798c3198918df89
Author: Hanks <zh...@gmail.com>
Date: 2017-07-26T08:28:18Z
* [jsfm] release v0.21.5
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #550: [jsfm] Fix potential memory leak in callbacks
Posted by Hanks10100 <gi...@git.apache.org>.
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex/pull/550
It's already merged in #559 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #550: [jsfm] Fix potential memory leak in callba...
Posted by Hanks10100 <gi...@git.apache.org>.
Github user Hanks10100 closed the pull request at:
https://github.com/apache/incubator-weex/pull/550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #550: [jsfm] Fix potential memory leak in callbacks
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/550
<!--
1 failure: This PR modify SD...
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @xkli , @Jinjiang to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---