You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/28 09:42:49 UTC

[GitHub] [lucene] jtibshirani opened a new pull request #229: LUCENE-10039: Fix single-field scoring for CombinedFieldQuery

jtibshirani opened a new pull request #229:
URL: https://github.com/apache/lucene/pull/229


   When there's only one field, CombinedFieldQuery will ignore its weight while
   scoring. This makes the scoring inconsistent, since the field weight is supposed
   to multiply its term frequency.
   
   This PR removes the optimizations around single-field scoring to make sure the
   weight is always taken into account. These optimizations don't seem critical
   since it should be rare for CombinedFieldQuery to run over only one field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jtibshirani merged pull request #229: LUCENE-10039: Fix single-field scoring for CombinedFieldQuery

Posted by GitBox <gi...@apache.org>.
jtibshirani merged pull request #229:
URL: https://github.com/apache/lucene/pull/229


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jtibshirani commented on pull request #229: LUCENE-10039: Fix single-field scoring for CombinedFieldQuery

Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #229:
URL: https://github.com/apache/lucene/pull/229#issuecomment-888241745


   Great point, the existing test `testCopyFieldWithMissingFields` only very rarely triggers this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org