You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/05/25 23:33:12 UTC
[GitHub] [hudi] yihua commented on a diff in pull request #8797: [HUDI-6260] Fix the MDT compaction reader with the instant range filt…
yihua commented on code in PR #8797:
URL: https://github.com/apache/hudi/pull/8797#discussion_r1206088234
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/HoodieCompactor.java:
##########
@@ -201,6 +209,7 @@ public List<WriteStatus> compact(HoodieCompactionHandler compactionHandler,
.withPartition(operation.getPartitionPath())
.withOptimizedLogBlocksScan(executionHelper.enableOptimizedLogBlockScan(config))
.withRecordMerger(config.getRecordMerger())
+ .withInstantRange(instantRange)
Review Comment:
Do we need this for all `HoodieMergedLogRecordScanner` builders? Have you revisited all such scanners?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org