[GitHub] [kafka] jlprat commented on a change in pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

[GitBox <gi...@apache.org>]

jlprat commented on a change in pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#discussion_r696609988



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -495,9 +498,25 @@ private void replaceStreamThread(final Throwable throwable) {
         }
     }
 
+    private StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse getActionForThrowable(final Throwable throwable,
+                                                                                        final StreamsUncaughtExceptionHandler streamsUncaughtExceptionHandler) {
+        final StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse action;
+        // Exception might we wrapped within a StreamsException one

Review comment:
       https://github.com/jlprat/kafka/blob/KAFKA-12887-no-trigger-exceptionhandler-for-rte/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java#L756
   This is where I can see RTE are always wrapped in a `StreamsException`. I'm not sure if this is always happening or there are cases in which the RTE is not wrapped.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org