You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "HattoriHenzo (via GitHub)" <gi...@apache.org> on 2023/03/21 02:53:13 UTC
[GitHub] [incubator-eventmesh] HattoriHenzo opened a new pull request, #3493: [ISSUE #3491] Refactor class StandaloneAdmin and RocketMQAdmin
HattoriHenzo opened a new pull request, #3493:
URL: https://github.com/apache/incubator-eventmesh/pull/3493
Fixes https://github.com/apache/incubator-eventmesh/issues/3491
### Motivation
Make some refactoring for class StandaloneAdmin and RocketMQAdmin.
### Modifications
Remove the `Propertie` parameter from the constructor.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 merged pull request #3493: [ISSUE #3491] Refactor class StandaloneAdmin and RocketMQAdmin
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 merged PR #3493:
URL: https://github.com/apache/incubator-eventmesh/pull/3493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3493: [ISSUE #3491] Refactor class StandaloneAdmin and RocketMQAdmin
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3493:
URL: https://github.com/apache/incubator-eventmesh/pull/3493#issuecomment-1478839017
## [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3493?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3493](https://codecov.io/gh/apache/incubator-eventmesh/pull/3493?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f5eb34) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/54cd00f38c7d15f015fbdfd156dcc44e0af89a9b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54cd00f) will **decrease** coverage by `0.02%`.
> The diff coverage is `37.50%`.
> :exclamation: Current head 0f5eb34 differs from pull request most recent head 36b41e2. Consider uploading reports for the commit 36b41e2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3493 +/- ##
============================================
- Coverage 14.62% 14.61% -0.02%
Complexity 1526 1526
============================================
Files 651 651
Lines 31711 31704 -7
Branches 3033 3018 -15
============================================
- Hits 4638 4633 -5
Misses 26657 26657
+ Partials 416 414 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ventmesh/storage/rocketmq/admin/RocketMQAdmin.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UvZXZlbnRtZXNoLXN0b3JhZ2Utcm9ja2V0bXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3JvY2tldG1xL2FkbWluL1JvY2tldE1RQWRtaW4uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...h/storage/rocketmq/admin/RocketMQAdminAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UvZXZlbnRtZXNoLXN0b3JhZ2Utcm9ja2V0bXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3JvY2tldG1xL2FkbWluL1JvY2tldE1RQWRtaW5BZGFwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...orage/standalone/admin/StandaloneAdminAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UvZXZlbnRtZXNoLXN0b3JhZ2Utc3RhbmRhbG9uZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3N0b3JhZ2Uvc3RhbmRhbG9uZS9hZG1pbi9TdGFuZGFsb25lQWRtaW5BZGFwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...mesh/storage/standalone/admin/StandaloneAdmin.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UvZXZlbnRtZXNoLXN0b3JhZ2Utc3RhbmRhbG9uZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3N0b3JhZ2Uvc3RhbmRhbG9uZS9hZG1pbi9TdGFuZGFsb25lQWRtaW4uamF2YQ==) | `92.30% <100.00%> (ø)` | |
... and [6 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-eventmesh/pull/3493/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org