You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/13 19:34:31 UTC

[GitHub] [beam] lostluck commented on a change in pull request #11670: [BEAM-9001, BEAM-6327] Ensure that all transforms (except for required runner implemented transforms) have an environment id.

lostluck commented on a change in pull request #11670:
URL: https://github.com/apache/beam/pull/11670#discussion_r424682770



##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -213,6 +213,7 @@ func (m *marshaller) addScopeTree(s *ScopeTree) string {
 	transform := &pipepb.PTransform{
 		UniqueName:    s.Scope.Name,
 		Subtransforms: subtransforms,
+		EnvironmentId: m.addDefaultEnv(),

Review comment:
       So, it's now the case that Composite Transforms *should* have environments?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org