You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by la...@apache.org on 2001/03/06 22:35:47 UTC
cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler JasperMangler.java
larryi 01/03/06 13:35:47
Modified: src/share/org/apache/jasper/compiler JasperMangler.java
Log:
Update init() method to change '/' character to File.separatorChar in pkgDir
for Windows systems. Jasper doesn't work well under Jdk1.1 on Windows
if classDir contains '/' characters.
Revision Changes Path
1.5 +5 -1 jakarta-tomcat/src/share/org/apache/jasper/compiler/JasperMangler.java
Index: JasperMangler.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/JasperMangler.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JasperMangler.java 2001/02/20 03:36:00 1.4
+++ JasperMangler.java 2001/03/06 21:35:46 1.5
@@ -222,7 +222,11 @@
pkgDir=JavaGeneratorTool.manglePackage(pkgDir);
pkgDir=pkgDir.replace('.', '_');
pkgDir=fixInvalidChars( pkgDir );
- classDir=workDir + File.separator + pkgDir;
+ if ( "/".equals(File.separator) )
+ classDir=workDir + File.separator + pkgDir;
+ else
+ classDir=workDir + File.separator +
+ pkgDir.replace('/',File.separatorChar);
} else {
classDir=workDir;
}
Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler
JasperMangler.java
Posted by Thomas Riemer <to...@58k.com>.
There is one more problem that you should consider while you are looking at this particular
code...
JasperMangler.java will generate incorrect class paths if you every have a number after a
separator /.
It will try to generate package starting with a number, which (obviously) doesn't work in java.
-Tom
larryi@apache.org wrote:
> larryi 01/03/06 13:35:47
>
> Modified: src/share/org/apache/jasper/compiler JasperMangler.java
> Log:
> Update init() method to change '/' character to File.separatorChar in pkgDir
> for Windows systems. Jasper doesn't work well under Jdk1.1 on Windows
> if classDir contains '/' characters.
>
> Revision Changes Path
> 1.5 +5 -1 jakarta-tomcat/src/share/org/apache/jasper/compiler/JasperMangler.java
>
> Index: JasperMangler.java
> ===================================================================
> RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/JasperMangler.java,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- JasperMangler.java 2001/02/20 03:36:00 1.4
> +++ JasperMangler.java 2001/03/06 21:35:46 1.5
> @@ -222,7 +222,11 @@
> pkgDir=JavaGeneratorTool.manglePackage(pkgDir);
> pkgDir=pkgDir.replace('.', '_');
> pkgDir=fixInvalidChars( pkgDir );
> - classDir=workDir + File.separator + pkgDir;
> + if ( "/".equals(File.separator) )
> + classDir=workDir + File.separator + pkgDir;
> + else
> + classDir=workDir + File.separator +
> + pkgDir.replace('/',File.separatorChar);
> } else {
> classDir=workDir;
> }
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, email: tomcat-dev-help@jakarta.apache.org