You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by rx...@apache.org on 2020/12/08 02:27:09 UTC

[pulsar] branch master updated: Enable spotbugs for pulsar-client-tools-test (#8847)

This is an automated email from the ASF dual-hosted git repository.

rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new d2510ad  Enable spotbugs for pulsar-client-tools-test (#8847)
d2510ad is described below

commit d2510ad55aaa628d8daa4ad6165a56de52194a4e
Author: xiaolong ran <rx...@apache.org>
AuthorDate: Tue Dec 8 10:26:38 2020 +0800

    Enable spotbugs for pulsar-client-tools-test (#8847)
    
    Signed-off-by: xiaolong.ran <rx...@apache.org>
    
    ### Motivation
    
    * Enable spotbugs for the pulsar-client-tools-test module.
    
    ### Modifications
    
    * Enable spotbugs for the pulsar-client-tools-test module.
    
    ### Verifying this change
    
    ```
    mvn clean install -pl pulsar-client-tools-test
    ```
---
 pulsar-client-tools-test/pom.xml                   | 17 +++++++++++++++++
 .../src/test/resources/findbugsExclude.xml         | 22 ++++++++++++++++++++++
 2 files changed, 39 insertions(+)

diff --git a/pulsar-client-tools-test/pom.xml b/pulsar-client-tools-test/pom.xml
index 0f5b221..f654df7 100644
--- a/pulsar-client-tools-test/pom.xml
+++ b/pulsar-client-tools-test/pom.xml
@@ -67,6 +67,23 @@
           <skip>true</skip>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
+        <version>${spotbugs-maven-plugin.version}</version>
+        <configuration>
+          <excludeFilterFile>${basedir}/src/test/resources/findbugsExclude.xml</excludeFilterFile>
+        </configuration>
+        <executions>
+          <execution>
+            <id>spotbugs</id>
+            <phase>verify</phase>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/pulsar-client-tools-test/src/test/resources/findbugsExclude.xml b/pulsar-client-tools-test/src/test/resources/findbugsExclude.xml
new file mode 100644
index 0000000..07f4609
--- /dev/null
+++ b/pulsar-client-tools-test/src/test/resources/findbugsExclude.xml
@@ -0,0 +1,22 @@
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+-->
+<FindBugsFilter>
+</FindBugsFilter>