You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/28 17:37:23 UTC
[GitHub] safrooze commented on a change in pull request #12689: Search
update
safrooze commented on a change in pull request #12689: Search update
URL: https://github.com/apache/incubator-mxnet/pull/12689#discussion_r221328455
##########
File path: docs/_static/js/docversion.js
##########
@@ -1,17 +1,17 @@
function setVersion(){
- let doc = window.location.pathname.match(/^\/(api\/.*)$/) || window.location.pathname.match(/^\/versions\/[^*]+\/(api\/.*)$/);
+ let doc = window.location.pathname.match(/^\/versions\/[0-9.master]+\/([^*]+.*)$/);
Review comment:
Wouldn't this fail if the version user is looking at is master, where `/versions/` is missing from the URL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services