[GitHub] [iceberg] rdblue commented on a diff in pull request #7370: Core: Make metrics reporter serializable

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7370:
URL: https://github.com/apache/iceberg/pull/7370#discussion_r1198346596


##########
.palantir/revapi.yml:
##########
@@ -456,6 +456,28 @@ acceptedBreaks:
       new: "parameter void org.apache.iceberg.actions.BaseCommitService<T>::offer(===T===)\
         \ @ org.apache.iceberg.actions.RewriteDataFilesCommitManager.CommitService"
       justification: "Backwards compatible parameterization of argument"
+    - code: "java.method.parameterTypeChanged"
+      old: "parameter void org.apache.iceberg.rest.RESTCatalog::<init>(===java.util.function.Function<java.util.Map<java.lang.String,\
+        \ java.lang.String>, org.apache.iceberg.rest.RESTClient>===)"
+      new: "parameter void org.apache.iceberg.rest.RESTCatalog::<init>(===org.apache.iceberg.util.SerializableFunction<java.util.Map<java.lang.String,\
+        \ java.lang.String>, org.apache.iceberg.rest.RESTClient>===)"
+      justification: "Switching to SerializableFunction"

Review Comment:
   Can we support both? I don't think we can make this change if it is a breaking one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org