You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/07 05:02:43 UTC
[GitHub] [hudi] the-other-tim-brown opened a new pull request, #6619: [HUDI-4796] MetricsReporter stop bug
the-other-tim-brown opened a new pull request, #6619:
URL: https://github.com/apache/hudi/pull/6619
### Change Logs
- Removes a confusing method, `getReporter()` in the abstract class MetricsReporter since we want to be calling `stop` the MetricsReporter instances to make sure they are cleaned up properly
- Updates Metrics.java to call `stop` method
- Updates implementations of MetricsReporter to no longer implement getReporter method
- Fixes import order in classes that were touched as part of this PR
### Impact
The API for the `MetricsReporter` is changing due to the removal of the `getReporter` method
**Risk level: low**
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6619:
URL: https://github.com/apache/hudi/pull/6619#issuecomment-1238937620
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 461a755d6938132f17243987fb7ab5e69a883f1e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6619:
URL: https://github.com/apache/hudi/pull/6619#issuecomment-1239462385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212",
"triggerID" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"triggerType" : "PUSH"
}, {
"hash" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 461a755d6938132f17243987fb7ab5e69a883f1e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212)
* 138acf4a157d61a6e5e42b0e86b270ae500d60a1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6619:
URL: https://github.com/apache/hudi/pull/6619#issuecomment-1239454983
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212",
"triggerID" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 461a755d6938132f17243987fb7ab5e69a883f1e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6619:
URL: https://github.com/apache/hudi/pull/6619#issuecomment-1239981498
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212",
"triggerID" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"triggerType" : "PUSH"
}, {
"hash" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11223",
"triggerID" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 138acf4a157d61a6e5e42b0e86b270ae500d60a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11223)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
yihua merged PR #6619:
URL: https://github.com/apache/hudi/pull/6619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6619:
URL: https://github.com/apache/hudi/pull/6619#issuecomment-1248772846
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212",
"triggerID" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"triggerType" : "PUSH"
}, {
"hash" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11223",
"triggerID" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"triggerType" : "PUSH"
}, {
"hash" : "7e9a46c5f5af4cf5881a0184373ce8501b2432d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11396",
"triggerID" : "7e9a46c5f5af4cf5881a0184373ce8501b2432d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 138acf4a157d61a6e5e42b0e86b270ae500d60a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11223)
* 7e9a46c5f5af4cf5881a0184373ce8501b2432d0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11396)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6619:
URL: https://github.com/apache/hudi/pull/6619#issuecomment-1238940922
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212",
"triggerID" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 461a755d6938132f17243987fb7ab5e69a883f1e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6619:
URL: https://github.com/apache/hudi/pull/6619#issuecomment-1248769946
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212",
"triggerID" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"triggerType" : "PUSH"
}, {
"hash" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11223",
"triggerID" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"triggerType" : "PUSH"
}, {
"hash" : "7e9a46c5f5af4cf5881a0184373ce8501b2432d0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e9a46c5f5af4cf5881a0184373ce8501b2432d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 138acf4a157d61a6e5e42b0e86b270ae500d60a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11223)
* 7e9a46c5f5af4cf5881a0184373ce8501b2432d0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #6619:
URL: https://github.com/apache/hudi/pull/6619#discussion_r972495605
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java:
##########
@@ -60,10 +59,8 @@ private void reportAndCloseReporter() {
try {
registerHoodieCommonMetrics();
reporter.report();
- if (getReporter() != null) {
- LOG.info("Closing metrics reporter...");
- getReporter().close();
- }
+ LOG.info("Stopping the metrics reporter...");
+ reporter.stop();
Review Comment:
minor. may be we can rename the method to `renameAndStopReporter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6619: [HUDI-4796] MetricsReporter stop bug
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6619:
URL: https://github.com/apache/hudi/pull/6619#issuecomment-1239469606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212",
"triggerID" : "461a755d6938132f17243987fb7ab5e69a883f1e",
"triggerType" : "PUSH"
}, {
"hash" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11223",
"triggerID" : "138acf4a157d61a6e5e42b0e86b270ae500d60a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 461a755d6938132f17243987fb7ab5e69a883f1e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11212)
* 138acf4a157d61a6e5e42b0e86b270ae500d60a1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11223)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org