You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2022/10/24 11:53:00 UTC

[jira] [Comment Edited] (CASSANDRA-17986) improve StartupException related codes

    [ https://issues.apache.org/jira/browse/CASSANDRA-17986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623134#comment-17623134 ] 

Stefan Miklosovic edited comment on CASSANDRA-17986 at 10/24/22 11:52 AM:
--------------------------------------------------------------------------

We should probably revisit the methods around this code to clean System.out logging as well. I am not completely sure if it done on purpose or not.

Suggested improvement in the description might be applied from 3.0 included.


was (Author: smiklosovic):
We should probably revisit the methods around this code to clean System.out logging as well. I am not completely sure if it done on purpose or not.

> improve StartupException related codes
> --------------------------------------
>
>                 Key: CASSANDRA-17986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Other
>            Reporter: Ling Mao
>            Priority: Normal
>
> 1. We should use the enum: _*ERR_WRONG_MACHINE_STATE*_ and *_ERR_WRONG_DISK_STATE_* to replace the magic number: 1 and 3
> {code:java}
> exitOrFail(1, e.getMessage(), e.getCause());
> exitOrFail(3, "Exception encountered during startup", e);{code}
>  
> 2. Delete the useless field: *_ERR_OUTDATED_SCHEMA_*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org