You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/13 11:42:40 UTC
[GitHub] [inlong] pocozh opened a new pull request, #5883: [INLONG-5874][Agent] Add msgTime attribute in PackProxyMessage
pocozh opened a new pull request, #5883:
URL: https://github.com/apache/inlong/pull/5883
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-5874][Agent] Add msgTime attribute in PackProxyMessage
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #5874
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] luchunliang commented on a diff in pull request #5883: [INLONG-5874][Agent] Add msgTime attribute in PackProxyMessage
Posted by GitBox <gi...@apache.org>.
luchunliang commented on code in PR #5883:
URL: https://github.com/apache/inlong/pull/5883#discussion_r969572502
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/ProxySink.java:
##########
@@ -104,11 +103,10 @@ public void write(Message message) {
}
// add message to package proxy
packProxyMessage.addProxyMessage(proxyMessage);
- //
+ // update msgTime
+ packProxyMessage.updateMsgTime(System.currentTimeMillis());
Review Comment:
It is better to use current time in Agent source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] pocozh commented on a diff in pull request #5883: [INLONG-5874][Agent] Add msgTime attribute in PackProxyMessage
Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #5883:
URL: https://github.com/apache/inlong/pull/5883#discussion_r970248614
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/ProxySink.java:
##########
@@ -104,11 +103,10 @@ public void write(Message message) {
}
// add message to package proxy
packProxyMessage.addProxyMessage(proxyMessage);
- //
+ // update msgTime
+ packProxyMessage.updateMsgTime(System.currentTimeMillis());
Review Comment:
> It is better to use current time in Agent source.
In `agent-source`, messages are encapsulated piece by piece. But, they are packaged to be sent to `dataproxy` with only one `msgTime`. So, is it better to use current time here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5883: [INLONG-5874][Agent] Use dataTime to report audit metrics
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5883:
URL: https://github.com/apache/inlong/pull/5883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] luchunliang commented on a diff in pull request #5883: [INLONG-5874][Agent] Add msgTime attribute in PackProxyMessage
Posted by GitBox <gi...@apache.org>.
luchunliang commented on code in PR #5883:
URL: https://github.com/apache/inlong/pull/5883#discussion_r969577682
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/ProxySink.java:
##########
@@ -104,11 +103,10 @@ public void write(Message message) {
}
// add message to package proxy
packProxyMessage.addProxyMessage(proxyMessage);
- //
+ // update msgTime
+ packProxyMessage.updateMsgTime(System.currentTimeMillis());
Review Comment:
Miss the modification about AUDIT_ID_AGENT_READ_SUCCESS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] luchunliang commented on a diff in pull request #5883: [INLONG-5874][Agent] Add msgTime attribute in PackProxyMessage
Posted by GitBox <gi...@apache.org>.
luchunliang commented on code in PR #5883:
URL: https://github.com/apache/inlong/pull/5883#discussion_r969577682
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/ProxySink.java:
##########
@@ -104,11 +103,10 @@ public void write(Message message) {
}
// add message to package proxy
packProxyMessage.addProxyMessage(proxyMessage);
- //
+ // update msgTime
+ packProxyMessage.updateMsgTime(System.currentTimeMillis());
Review Comment:
Miss the modification about AUDIT_ID_AGENT_READ_SUCCESS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org