[jira] [Commented] (CAMEL-9945) Upgrade to jetty 9.3

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828103#comment-15828103 ] 

ASF GitHub Bot commented on CAMEL-9945:
---------------------------------------

GitHub user zregvart opened a pull request:

    https://github.com/apache/camel/pull/1407

    CAMEL-9945 Upgrade to jetty 9.3

    Java compiler uses the actual return type of the method in the compiled
    class and as the signature of
    `org.eclipse.jetty.client.HttpClient::getProtocolHandlers` method
    changed between Jetty 9.2 and 9.3 in return type it could be compiled
    and run against both versions, but it could not be compiled with one
    version and run against another.
    
    This commit uses reflection when calling `getProtocolHandlers` method to
    maintain compatibility with 9.2 and 9.3 versions of Jetty regardless of
    compile time vs runtime version.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zregvart/camel CAMEL-9945

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1407
    
----
commit 1c025cc129dce1d70b8f18ba1d9b104669d16255
Author: Zoran Regvart <zo...@regvart.com>
Date:   2017-01-18T13:54:00Z

    CAMEL-9945 Upgrade to jetty 9.3
    
    Java compiler uses the actual return type of the method in the compiled
    class and as the signature of
    `org.eclipse.jetty.client.HttpClient::getProtocolHandlers` method
    changed between Jetty 9.2 and 9.3 in return type it could be compiled
    and run against both versions, but it could not be compiled with one
    version and run against another.
    
    This commit uses reflection when calling `getProtocolHandlers` method to
    maintain compatibility with 9.2 and 9.3 versions of Jetty regardless of
    compile time vs runtime version.

----


> Upgrade to jetty 9.3
> --------------------
>
>                 Key: CAMEL-9945
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9945
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-jetty
>            Reporter: Claus Ibsen
>            Assignee: Zoran Regvart
>             Fix For: 2.19.0
>
>
> We should upgrade to jetty 9.3, but it breaks its api from 9.2 to 9.3.
> There is a branch here with a commit with a start
> https://github.com/apache/camel/tree/jetty93
> Some tests in camel-jetty9 now fails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)