You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/07 04:07:37 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #26114: Make `execution_date_or_run_id` optional in `tasks test` command

uranusjr commented on code in PR #26114:
URL: https://github.com/apache/airflow/pull/26114#discussion_r964362250


##########
airflow/cli/commands/task_command.py:
##########
@@ -75,9 +75,9 @@ def _generate_temporary_run_id() -> str:
 def _get_dag_run(
     *,
     dag: DAG,
-    exec_date_or_run_id: str,
     create_if_necessary: CreateIfNecessary,
-    session: Session,
+    exec_date_or_run_id: Optional[str] = None,
+    session: Session = NEW_SESSION,

Review Comment:
   All arguments in this function are keyword-only, so ordering does not matter. You can add the new argument anywhere (but behind `*`) and keep all other arguments as-is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org