[GitHub] [spark] Yikun commented on a change in pull request #35422: [SPARK-36061][K8S] Add Volcano feature step and enable user specified minimum resources

[GitBox <gi...@apache.org>]

Yikun commented on a change in pull request #35422:
URL: https://github.com/apache/spark/pull/35422#discussion_r800606221



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -675,6 +676,20 @@ private[spark] object Config extends Logging {
       .checkValue(value => value > 0, "Maximum number of pending pods should be a positive integer")
       .createWithDefault(Int.MaxValue)
 
+  val KUBERNETES_JOB_MIN_MEMORY = ConfigBuilder("spark.kubernetes.job.min.memory")

Review comment:
       We have some discussion on this with Yunikorn and Volcano team, we finally think `spark.kubernetes.job` is better than  `spark.kubernetes.xxx.job`:
   - There are many other common arguments like queue, priorityClass, for this general parameter, we can extract to avoid 
   redundant of configuration.
   - Other customized scheduler can also use this configuration directly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org