You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Suma Shivaprasad <su...@gmail.com> on 2014/09/08 19:25:11 UTC

Re: Review Request 24630: HIVE-7694 - SMB joins on tables differing by number of sorted by columns but same sort prefix and join keys fail

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24630/
-----------------------------------------------------------

(Updated Sept. 8, 2014, 5:25 p.m.)


Review request for hive, Amareshwari Sriramadasu, Brock Noland, Gunther Hagleitner, and Navis Ryu.


Changes
-------

Added another reviewer


Bugs: HIVE-7694
    https://issues.apache.org/jira/browse/HIVE-7694


Repository: hive-git


Description
-------

For eg: If two tables T1 sorted by (a, b, c) clustered by a and T2 sorted by (a) and clustered by (a) are joined, an exception is seen as reported in https://issues.apache.org/jira/browse/HIVE-7694


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 0b7b1a3 
  ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q PRE-CREATION 
  ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24630/diff/


Testing (updated)
-------

sort_merge_join_desc_8.q added for testing the above cases


Thanks,

Suma Shivaprasad


Re: Review Request 24630: HIVE-7694 - SMB joins on tables differing by number of sorted by columns but same sort prefix and join keys fail

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24630/#review52695
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Sept. 8, 2014, 5:25 p.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24630/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 5:25 p.m.)
> 
> 
> Review request for hive, Amareshwari Sriramadasu, Brock Noland, Gunther Hagleitner, and Navis Ryu.
> 
> 
> Bugs: HIVE-7694
>     https://issues.apache.org/jira/browse/HIVE-7694
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> For eg: If two tables T1 sorted by (a, b, c) clustered by a and T2 sorted by (a) and clustered by (a) are joined, an exception is seen as reported in https://issues.apache.org/jira/browse/HIVE-7694
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 0b7b1a3 
>   ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q PRE-CREATION 
>   ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24630/diff/
> 
> 
> Testing
> -------
> 
> sort_merge_join_desc_8.q added for testing the above cases
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>