You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Darren Shepherd <da...@gmail.com> on 2013/09/18 01:25:12 UTC
Review Request 14187: Framework to discover and load spring contexts in a
hierarchy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14187/
-----------------------------------------------------------
Review request for cloudstack, Alex Huang and Kelven Yang.
Repository: cloudstack-git
Description
-------
This is a small framework to discover Spring XML files and then load then in a hierarchy of application contexts. This patch adds the new project but does not add it to the build. That will come later.
Diffs
-----
framework/spring/module/pom.xml PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/context/ResourceApplicationContext.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/factory/CloudStackSpringContext.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/factory/ModuleBasedContextFactory.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/locator/ModuleDefinitionLocator.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/locator/impl/ClasspathModuleDefinitionLocator.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/ModuleDefinition.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/ModuleDefinitionSet.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinition.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/util/Main.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/util/ModuleLocationUtils.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/web/CloudStackContextLoaderListener.java PRE-CREATION
framework/spring/module/src/main/resources/org/apache/cloudstack/spring/module/model/impl/defaults-context.xml PRE-CREATION
framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/factory/ModuleBasedContextFactoryTest.java PRE-CREATION
framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/locator/impl/ClasspathModuleDefinitionSetLocatorTest.java PRE-CREATION
framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionTest.java PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/defaults.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/empty-context-inheritable.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/empty-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/empty2-context-inheritable.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/empty2-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/test2-defaults.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/badname/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/blankname/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/good/empty-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/good/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/missingname/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/wrongname/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/base/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/base/test-context-inheritable.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/base/test-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child1-1/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child1-1/test-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child1/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child1/test-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child2/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child2/test-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/orphan1/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/orphan1/test-context.xml PRE-CREATION
Diff: https://reviews.apache.org/r/14187/diff/
Testing
-------
Thanks,
Darren Shepherd
Re: Review Request 14187: Framework to discover and load spring contexts in
a hierarchy
Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14187/#review26516
-----------------------------------------------------------
Ship it!
Ship It!
- Kelven Yang
On Sept. 18, 2013, 5:51 p.m., Darren Shepherd wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14187/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2013, 5:51 p.m.)
>
>
> Review request for cloudstack, Alex Huang and Kelven Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is a small framework to discover Spring XML files and then load then in a hierarchy of application contexts. This patch adds the new project but does not add it to the build. That will come later.
>
>
> Diffs
> -----
>
> framework/spring/module/pom.xml PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/context/ResourceApplicationContext.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/factory/CloudStackSpringContext.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/factory/ModuleBasedContextFactory.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/locator/ModuleDefinitionLocator.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/locator/impl/ClasspathModuleDefinitionLocator.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/ModuleDefinition.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/ModuleDefinitionSet.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinition.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/util/Main.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/util/ModuleLocationUtils.java PRE-CREATION
> framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/web/CloudStackContextLoaderListener.java PRE-CREATION
> framework/spring/module/src/main/resources/org/apache/cloudstack/spring/module/model/impl/defaults-context.xml PRE-CREATION
> framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/factory/ModuleBasedContextFactoryTest.java PRE-CREATION
> framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/locator/impl/ClasspathModuleDefinitionSetLocatorTest.java PRE-CREATION
> framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionTest.java PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/all/defaults.properties PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/all/empty-context-inheritable.xml PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/all/empty-context.xml PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/all/empty2-context-inheritable.xml PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/all/empty2-context.xml PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/all/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/all/test2-defaults.properties PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/badname/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/blankname/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/good/empty-context.xml PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/good/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/missingname/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testfiles/wrongname/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/base/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/base/test-context-inheritable.xml PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/base/test-context.xml PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/child1-1/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/child1-1/test-context.xml PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/child1/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/child1/test-context.xml PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/child2/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/child2/test-context.xml PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/orphan1/module.properties PRE-CREATION
> framework/spring/module/src/test/resources/testhierarchy/orphan1/test-context.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14187/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Darren Shepherd
>
>
Re: Review Request 14187: Framework to discover and load spring contexts in
a hierarchy
Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14187/
-----------------------------------------------------------
(Updated Sept. 18, 2013, 5:51 p.m.)
Review request for cloudstack, Alex Huang and Kelven Yang.
Changes
-------
If you want to build this module you need rb14186 also as it has the parent pom in it
Repository: cloudstack-git
Description
-------
This is a small framework to discover Spring XML files and then load then in a hierarchy of application contexts. This patch adds the new project but does not add it to the build. That will come later.
Diffs
-----
framework/spring/module/pom.xml PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/context/ResourceApplicationContext.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/factory/CloudStackSpringContext.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/factory/ModuleBasedContextFactory.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/locator/ModuleDefinitionLocator.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/locator/impl/ClasspathModuleDefinitionLocator.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/ModuleDefinition.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/ModuleDefinitionSet.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinition.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/util/Main.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/util/ModuleLocationUtils.java PRE-CREATION
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/web/CloudStackContextLoaderListener.java PRE-CREATION
framework/spring/module/src/main/resources/org/apache/cloudstack/spring/module/model/impl/defaults-context.xml PRE-CREATION
framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/factory/ModuleBasedContextFactoryTest.java PRE-CREATION
framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/locator/impl/ClasspathModuleDefinitionSetLocatorTest.java PRE-CREATION
framework/spring/module/src/test/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionTest.java PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/defaults.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/empty-context-inheritable.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/empty-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/empty2-context-inheritable.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/empty2-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/all/test2-defaults.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/badname/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/blankname/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/good/empty-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testfiles/good/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/missingname/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testfiles/wrongname/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/base/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/base/test-context-inheritable.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/base/test-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child1-1/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child1-1/test-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child1/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child1/test-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child2/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/child2/test-context.xml PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/orphan1/module.properties PRE-CREATION
framework/spring/module/src/test/resources/testhierarchy/orphan1/test-context.xml PRE-CREATION
Diff: https://reviews.apache.org/r/14187/diff/
Testing
-------
Thanks,
Darren Shepherd