Removing cluster support for 7.1.x

["Alan M. Carroll" <am...@network-geographics.com>]

Oath has developed an internal patch for our 7.1.x fork which removes cluster support. This is effectively a back port of changes that are already on master. The question is whether it would be OK to submit as a backport to 7.1.3. It's fairly large but it should make backporting from master to 7.1.x easier. I chatted with Leif as the RM for 7.1.x and he had no objection but wanted to leave it up to the community. I'm +1 on this. As far as I know, clustering is already official disabled for 7.1.x and so this doesn't represent a functionality or API change.

Re: Removing cluster support for 7.1.x

[Walt Karas <wk...@oath.com.INVALID>]

I tried cherry-picking this from Apache master to Oath 7.1.x, but
there were too many conflicts.  Perhaps it would work to cherry-pick
form Oath 7.1.x to Apache 7.1.x .  It also seems to me like an issue
with semantic labeling to put it in 7.1.x not 7.2 .

Walt

On Fri, Jan 19, 2018 at 12:29 AM, Leif Hedstrom <zw...@apache.org> wrote:
>
>
>> On Jan 17, 2018, at 4:15 AM, Phil Sorber <so...@apache.org> wrote:
>>
>> We haven't made changes that enable clustering, but I believe this is a
>> large change and seems like a bad idea in a minor release. If I were the RM
>> I'd -1 it, but since I am not, I'll just express my concern.
>
>
>
> I agree that it’s slightly sketchy, but I think the upsides as noticeable (easier to cherry-pick from master to 7.1.x branch). Also, I believe this PR is a cherry-pick + fixes from master to the 7.1.x branch? If so, please make sure the cherry pick(s) are done with “cherry-pick -x”.
>
> I was contemplating if this would be better for a 7.2.x release, but alas, that forces us into supporting both 7.1.x and 7.2.x for a while. But, if you guys have other feature changes queued up for 7.x, that need to go into a 7.2.x release, then that would be the better choice here.
>
> Cheers,
>
> — Leif
>

Re: Removing cluster support for 7.1.x

[Leif Hedstrom <zw...@apache.org>]

> On Jan 17, 2018, at 4:15 AM, Phil Sorber <so...@apache.org> wrote:
> 
> We haven't made changes that enable clustering, but I believe this is a
> large change and seems like a bad idea in a minor release. If I were the RM
> I'd -1 it, but since I am not, I'll just express my concern.



I agree that it’s slightly sketchy, but I think the upsides as noticeable (easier to cherry-pick from master to 7.1.x branch). Also, I believe this PR is a cherry-pick + fixes from master to the 7.1.x branch? If so, please make sure the cherry pick(s) are done with “cherry-pick -x”.

I was contemplating if this would be better for a 7.2.x release, but alas, that forces us into supporting both 7.1.x and 7.2.x for a while. But, if you guys have other feature changes queued up for 7.x, that need to go into a 7.2.x release, then that would be the better choice here.

Cheers,

— Leif

Re: Removing cluster support for 7.1.x

[Phil Sorber <so...@apache.org>]

We haven't made changes that enable clustering, but I believe this is a
large change and seems like a bad idea in a minor release. If I were the RM
I'd -1 it, but since I am not, I'll just express my concern.

Thanks.

On Tue, Jan 16, 2018 at 9:32 AM Bryan Call <bc...@apache.org> wrote:

> I am +1 on removing the code.
>
> I would like to hear from anyone in the community if they have modified
> the 7.x release (enable clustering) and are using it.
>
> -Bryan
>
>
>
> > On Jan 11, 2018, at 9:26 AM, Alan M. Carroll <
> amc@network-geographics.com> wrote:
> >
> > Oath has developed an internal patch for our 7.1.x fork which removes
> cluster support. This is effectively a back port of changes that are
> already on master. The question is whether it would be OK to submit as a
> backport to 7.1.3. It's fairly large but it should make backporting from
> master to 7.1.x easier. I chatted with Leif as the RM for 7.1.x and he had
> no objection but wanted to leave it up to the community. I'm +1 on this. As
> far as I know, clustering is already official disabled for 7.1.x and so
> this doesn't represent a functionality or API change.
> >
>
>

Re: Removing cluster support for 7.1.x

[Bryan Call <bc...@apache.org>]

I am +1 on removing the code. 

I would like to hear from anyone in the community if they have modified the 7.x release (enable clustering) and are using it.

-Bryan



> On Jan 11, 2018, at 9:26 AM, Alan M. Carroll <am...@network-geographics.com> wrote:
> 
> Oath has developed an internal patch for our 7.1.x fork which removes cluster support. This is effectively a back port of changes that are already on master. The question is whether it would be OK to submit as a backport to 7.1.3. It's fairly large but it should make backporting from master to 7.1.x easier. I chatted with Leif as the RM for 7.1.x and he had no objection but wanted to leave it up to the community. I'm +1 on this. As far as I know, clustering is already official disabled for 7.1.x and so this doesn't represent a functionality or API change.
> 

Re: Removing cluster support for 7.1.x

["Steven R. Feltner" <sf...@godaddy.com>]

I am +1 on this.  Clustering hasn’t worked in quite a few releases.  This would be removing the unnecessary cruft that was clustering.

Thanks,
Steven 

On 1/11/18, 1:26 PM, "Alan M. Carroll" <am...@network-geographics.com> wrote:

    Oath has developed an internal patch for our 7.1.x fork which removes cluster support. This is effectively a back port of changes that are already on master. The question is whether it would be OK to submit as a backport to 7.1.3. It's fairly large but it should make backporting from master to 7.1.x easier. I chatted with Leif as the RM for 7.1.x and he had no objection but wanted to leave it up to the community. I'm +1 on this. As far as I know, clustering is already official disabled for 7.1.x and so this doesn't represent a functionality or API change.