You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/31 11:46:32 UTC
[GitHub] [beam] bullet03 opened a new pull request, #22968: [Website] update site navigation #22902
bullet03 opened a new pull request, #22968:
URL: https://github.com/apache/beam/pull/22968
Resolves #22902
- move Learning Resources from documentation section to get-started
- add [Spark page](https://beam.apache.org/get-started/from-spark/) to Quickstarts navigation menu after menu
------------------------
before:
after:
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #22968: [Website] update site navigation #22902
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22968:
URL: https://github.com/apache/beam/pull/22968#issuecomment-1239207245
> Thanks!
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #22968: [Website] update site navigation #22902
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #22968:
URL: https://github.com/apache/beam/pull/22968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on a diff in pull request #22968: [Website] update site navigation #22902
Posted by GitBox <gi...@apache.org>.
bullet03 commented on code in PR #22968:
URL: https://github.com/apache/beam/pull/22968#discussion_r971257584
##########
website/www/site/layouts/partials/section-menu/en/get-started.html:
##########
@@ -37,16 +38,16 @@
<span class="section-nav-list-title">Learning resources</span>
<ul class="section-nav-list">
- <li><a href="/documentation/resources/learning-resources/#getting-started">Getting Started</a></li>
Review Comment:
Thank you for your point. Added an aliases to learning-resources.md, so now there is a redirect to correct path /get-started/resources/learning-resources even in case somebody uses /documentation/resources/learning-resources, so there will be no 404 error in case of old web search or others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #22968: [Website] update site navigation #22902
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #22968:
URL: https://github.com/apache/beam/pull/22968#discussion_r967103739
##########
website/www/site/layouts/partials/section-menu/en/get-started.html:
##########
@@ -37,16 +38,16 @@
<span class="section-nav-list-title">Learning resources</span>
<ul class="section-nav-list">
- <li><a href="/documentation/resources/learning-resources/#getting-started">Getting Started</a></li>
Review Comment:
Should it cause an increase of 404 requests that will use old URLs (e.g. web search)?
Should we add redirects in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #22968: [Website] update site navigation #22902
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #22968:
URL: https://github.com/apache/beam/pull/22968#discussion_r972094538
##########
website/www/site/layouts/partials/section-menu/en/get-started.html:
##########
@@ -37,16 +38,16 @@
<span class="section-nav-list-title">Learning resources</span>
<ul class="section-nav-list">
- <li><a href="/documentation/resources/learning-resources/#getting-started">Getting Started</a></li>
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alevtinaboiko commented on pull request #22968: [Website] update site navigation #22902
Posted by GitBox <gi...@apache.org>.
alevtinaboiko commented on PR #22968:
URL: https://github.com/apache/beam/pull/22968#issuecomment-1235497286
Verified, works as expected. Reviewed and tested by QA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #22968: [Website] update site navigation #22902
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22968:
URL: https://github.com/apache/beam/pull/22968#issuecomment-1237420241
@pcoet, could you, please, review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #22968: [Website] update site navigation #22902
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22968:
URL: https://github.com/apache/beam/pull/22968#issuecomment-1241880258
@aromanenko-dev, could you, please help with merge? PR was approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org