You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by th...@apache.org on 2016/06/02 03:16:10 UTC

[11/12] tika git commit: Using TikaConfigException instead of RuntimeException

Using TikaConfigException instead of RuntimeException

Project: http://git-wip-us.apache.org/repos/asf/tika/repo
Commit: http://git-wip-us.apache.org/repos/asf/tika/commit/67941a63
Tree: http://git-wip-us.apache.org/repos/asf/tika/tree/67941a63
Diff: http://git-wip-us.apache.org/repos/asf/tika/diff/67941a63

Branch: refs/heads/TIKA-1508
Commit: 67941a63949280289c1a7b5430a86de0aa3838a9
Parents: aad23d9
Author: Thamme Gowda <tg...@gmail.com>
Authored: Wed Jun 1 16:36:27 2016 -0700
Committer: Thamme Gowda <tg...@gmail.com>
Committed: Wed Jun 1 16:36:27 2016 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/tika/config/ParamField.java | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tika/blob/67941a63/tika-core/src/main/java/org/apache/tika/config/ParamField.java
----------------------------------------------------------------------
diff --git a/tika-core/src/main/java/org/apache/tika/config/ParamField.java b/tika-core/src/main/java/org/apache/tika/config/ParamField.java
index 96063dc..281dd98 100644
--- a/tika-core/src/main/java/org/apache/tika/config/ParamField.java
+++ b/tika-core/src/main/java/org/apache/tika/config/ParamField.java
@@ -16,6 +16,8 @@
  */
 package org.apache.tika.config;
 
+import org.apache.tika.exception.TikaConfigException;
+
 import java.lang.reflect.*;
 import java.util.HashMap;
 import java.util.Locale;
@@ -54,7 +56,7 @@ public class ParamField {
      * Creates a ParamField object
      * @param member a field or method which has {@link Field} annotation
      */
-    public ParamField(AccessibleObject member){
+    public ParamField(AccessibleObject member) throws TikaConfigException {
         if (member instanceof java.lang.reflect.Field) {
             field = (java.lang.reflect.Field) member;
         } else {
@@ -113,20 +115,19 @@ public class ParamField {
         }
     }
 
-    private Class retrieveType() {
+    private Class retrieveType() throws TikaConfigException {
         Class type;
         if (field != null) {
             type = field.getType();
         } else {
             Class[] params = setter.getParameterTypes();
             if (params.length != 1) {
-                //todo:Tika config exception
                 String msg = "Invalid setter method. Must have one and only one parameter. ";
                 if (setter.getName().startsWith("get")) {
                     msg += "Perhaps the annotation is misplaced on " +
-                            setter.getName() +" while a set'X' is expected?";
+                            setter.getName() + " while a set'X' is expected?";
                 }
-                throw new RuntimeException(msg);
+                throw new TikaConfigException(msg);
             }
             type = params[0];
         }