You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2023/11/14 23:15:31 UTC
[PR] MINOR: [C++][Docs] Add \deprecated tag to deprecated BufferReader constructors [arrow]
amoeba opened a new pull request, #38721:
URL: https://github.com/apache/arrow/pull/38721
### Rationale for this change
The PR [GH-37360](https://github.com/apache/arrow/pull/37360) for issue [GH-37212](https://github.com/apache/arrow/issues/37212) deprecated three BufferReader constructors and I noticed one of them was missing a `\deprecated` command.
### What changes are included in this PR?
This adds a `\deprecated` command one of the deprecated constructors with a message. The other two didn't need it because they weren't already documented. i.e., they weren't listed under https://arrow.apache.org/docs/cpp/api/io.html so documenting them at this point just to add `\deprecated` wouldn't make sense.
### Are these changes tested?
No, this is a simple docs change.
### Are there any user-facing changes?
Yes, this adds a notice to the docs for this particular method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][Docs] Add \deprecated tag to deprecated BufferReader constructor [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #38721:
URL: https://github.com/apache/arrow/pull/38721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][Docs] Add \deprecated tag to deprecated BufferReader constructor [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38721:
URL: https://github.com/apache/arrow/pull/38721#issuecomment-1823930946
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 65fc1e71faf9d5129fc3fa699b6779bfd444364a.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/18957720803) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org