You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2020/02/07 12:36:38 UTC
[GitHub] [griffin] chitralverma opened a new pull request #568: []Refactor
data connector config
chitralverma opened a new pull request #568: []Refactor data connector config
URL: https://github.com/apache/griffin/pull/568
**What changes were proposed in this pull request?**
This ticket proposes the following changes,
- remove 'version' from 'DataConnectorParam' as it is not being used anywhere in the codebase.
- change 'connectors' from array type to a single JSON object. Since a data source named X may only be of one type (hive, file etc), the connector field should not be an array.
- rename connectors to connector
**Does this PR introduce any user-facing change?**
Yes. As mentioned above, the config structure has changed now.
**How was this patch tested?**
Griffin test suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] pshingavi edited a comment on issue #568: [GRIFFIN-323]
Refactor configuration Data Source Connector
Posted by GitBox <gi...@apache.org>.
pshingavi edited a comment on issue #568: [GRIFFIN-323] Refactor configuration Data Source Connector
URL: https://github.com/apache/griffin/pull/568#issuecomment-601343027
I do not see a change in the service code to accept this change in contract. When I submit with 'connectors' from the UI the request goes through but fails while executing the job (log snippet below) and with 'connector' does not work in the service API call since it's expecting 'connectors' to submit a measure. Am I missing something here?
`20/03/19 18:27:26 ERROR Application$: assertion failed: Connector is undefined or invalid
java.lang.AssertionError: assertion failed: Connector is undefined or invalid
at scala.Predef$.assert(Predef.scala:170)
at org.apache.griffin.measure.configuration.dqdefinition.DataSourceParam.validate(DQConfig.scala:100)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] pshingavi commented on issue #568: [GRIFFIN-323] Refactor
configuration Data Source Connector
Posted by GitBox <gi...@apache.org>.
pshingavi commented on issue #568: [GRIFFIN-323] Refactor configuration Data Source Connector
URL: https://github.com/apache/griffin/pull/568#issuecomment-601343027
I do not see a change in the service code to accept this change in contract. When I submit with 'connectors' from the UI the request goes through but 'connector' does not work in the service API call to submit a measure. Am I missing something here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] asfgit closed pull request #568: [GRIFFIN-323] Refactor
configuration Data Source Connector
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #568: [GRIFFIN-323] Refactor configuration Data Source Connector
URL: https://github.com/apache/griffin/pull/568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] chitralverma commented on issue #568: [GRIFFIN-323]
Refactor configuration Data Source Connector
Posted by GitBox <gi...@apache.org>.
chitralverma commented on issue #568: [GRIFFIN-323] Refactor configuration Data Source Connector
URL: https://github.com/apache/griffin/pull/568#issuecomment-601345695
Yes these changes are not supported by the current ui and services
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] wankunde commented on issue #568: [GRIFFIN-323] Refactor
configuration Data Source Connector
Posted by GitBox <gi...@apache.org>.
wankunde commented on issue #568: [GRIFFIN-323] Refactor configuration Data Source Connector
URL: https://github.com/apache/griffin/pull/568#issuecomment-584023181
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] pshingavi commented on issue #568: [GRIFFIN-323] Refactor
configuration Data Source Connector
Posted by GitBox <gi...@apache.org>.
pshingavi commented on issue #568: [GRIFFIN-323] Refactor configuration Data Source Connector
URL: https://github.com/apache/griffin/pull/568#issuecomment-601346796
What's the compatible commit I can use in this case ? Just before this was merged may be ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services