You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Saman Alvi <sa...@pivotal.io> on 2014/10/16 22:05:25 UTC

Review Request 26819: Metrics graph displayed on service pages should be defined in configuration files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26819/
-----------------------------------------------------------

Review request for Ambari.


Repository: ambari


Description
-------

Metrics graph displayed on service pages should be defined in configuration files


Diffs
-----

  ambari-web/app/assets/test/tests.js bcc835b 
  ambari-web/app/data/service_graph_config.js PRE-CREATION 
  ambari-web/app/views/main/service/info/summary.js d90f835 
  ambari-web/test/views/main/service/info/summary_test.js 8392ad0 

Diff: https://reviews.apache.org/r/26819/diff/


Testing
-------


Thanks,

Saman Alvi


Re: Review Request 26819: Metrics graph displayed on service pages should be defined in configuration files

Posted by Saman Alvi <sa...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26819/
-----------------------------------------------------------

(Updated Oct. 17, 2014, 2:23 p.m.)


Review request for Ambari.


Bugs: AMBARI-7601
    https://issues.apache.org/jira/browse/AMBARI-7601


Repository: ambari


Description
-------

Metrics graph displayed on service pages should be defined in configuration files


Diffs
-----

  ambari-web/app/assets/test/tests.js bcc835b 
  ambari-web/app/data/service_graph_config.js PRE-CREATION 
  ambari-web/app/views/main/service/info/summary.js d90f835 
  ambari-web/test/views/main/service/info/summary_test.js 8392ad0 

Diff: https://reviews.apache.org/r/26819/diff/


Testing
-------


Thanks,

Saman Alvi


Re: Review Request 26819: Metrics graph displayed on service pages should be defined in configuration files

Posted by Grace Li <gl...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26819/#review56992
-----------------------------------------------------------

Ship it!


Ship It!

- Grace Li


On Oct. 16, 2014, 8:06 p.m., Saman Alvi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26819/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 8:06 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Metrics graph displayed on service pages should be defined in configuration files
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js bcc835b 
>   ambari-web/app/data/service_graph_config.js PRE-CREATION 
>   ambari-web/app/views/main/service/info/summary.js d90f835 
>   ambari-web/test/views/main/service/info/summary_test.js 8392ad0 
> 
> Diff: https://reviews.apache.org/r/26819/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saman Alvi
> 
>


Re: Review Request 26819: Metrics graph displayed on service pages should be defined in configuration files

Posted by Saman Alvi <sa...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26819/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 8:06 p.m.)


Review request for Ambari.


Repository: ambari


Description
-------

Metrics graph displayed on service pages should be defined in configuration files


Diffs (updated)
-----

  ambari-web/app/assets/test/tests.js bcc835b 
  ambari-web/app/data/service_graph_config.js PRE-CREATION 
  ambari-web/app/views/main/service/info/summary.js d90f835 
  ambari-web/test/views/main/service/info/summary_test.js 8392ad0 

Diff: https://reviews.apache.org/r/26819/diff/


Testing
-------


Thanks,

Saman Alvi