You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2006/06/06 14:02:16 UTC

[jira] Created: (SB-28) Changes to enable DefinitionsFactory customization

Changes to enable DefinitionsFactory customization
--------------------------------------------------

         Key: SB-28
         URL: http://issues.apache.org/struts/browse/SB-28
     Project: Sandbox
        Type: Improvement

  Components: Standalone Tiles  
 Environment: All
    Reporter: Antonio Petrelli
    Priority: Minor


In this issue, I will post a patch that:
- changes the way DefinitionsFactory is defined, i.e. it now uses TilesContext instead of Locale;
- changes to TilesContextFactory, that now is a (potentially configurable) normal class instead of a class with static methods.
- contains the patches described in:
http://issues.apache.org/struts/browse/SB-24
http://issues.apache.org/struts/browse/SB-26
http://issues.apache.org/struts/browse/SB-27

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (SB-28) Changes to enable DefinitionsFactory customization

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/SB-28?page=all ]

Antonio Petrelli updated SB-28:
-------------------------------

    Attachment: tiles-patch-2006_09_11.zip

Uploaded an updated version of the patch.
Now it does not depend on any previous patch.
It does not redefine TilesContextFactory too, I would like to leave it to another issue.

> Changes to enable DefinitionsFactory customization
> --------------------------------------------------
>
>                 Key: SB-28
>                 URL: http://issues.apache.org/struts/browse/SB-28
>             Project: Sandbox
>          Issue Type: Improvement
>          Components: Tiles
>         Environment: All
>            Reporter: Antonio Petrelli
>            Priority: Minor
>         Attachments: tiles-patch-2006_09_11.zip, tiles-patch.zip
>
>
> In this issue, I will post a patch that:
> - changes the way DefinitionsFactory is defined, i.e. it now uses TilesContext instead of Locale;
> - changes to TilesContextFactory, that now is a (potentially configurable) normal class instead of a class with static methods.
> - contains the patches described in:
> http://issues.apache.org/struts/browse/SB-24
> http://issues.apache.org/struts/browse/SB-26
> http://issues.apache.org/struts/browse/SB-27

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (SB-28) Changes to enable DefinitionsFactory customization

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/SB-28?page=all ]

Antonio Petrelli reassigned SB-28:
----------------------------------

    Assignee: Antonio Petrelli

> Changes to enable DefinitionsFactory customization
> --------------------------------------------------
>
>                 Key: SB-28
>                 URL: http://issues.apache.org/struts/browse/SB-28
>             Project: Sandbox
>          Issue Type: Improvement
>          Components: Tiles
>         Environment: All
>            Reporter: Antonio Petrelli
>         Assigned To: Antonio Petrelli
>            Priority: Minor
>         Attachments: tiles-patch-2006_09_11.zip, tiles-patch.zip
>
>
> In this issue, I will post a patch that:
> - changes the way DefinitionsFactory is defined, i.e. it now uses TilesContext instead of Locale;
> - changes to TilesContextFactory, that now is a (potentially configurable) normal class instead of a class with static methods.
> - contains the patches described in:
> http://issues.apache.org/struts/browse/SB-24
> http://issues.apache.org/struts/browse/SB-26
> http://issues.apache.org/struts/browse/SB-27

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SB-28) Changes to enable DefinitionsFactory customization

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/SB-28?page=all ]

Antonio Petrelli updated SB-28:
-------------------------------

    Attachment: tiles-patch.zip

Patch made with svn:diff inside Eclipse (Subclipse).

> Changes to enable DefinitionsFactory customization
> --------------------------------------------------
>
>          Key: SB-28
>          URL: http://issues.apache.org/struts/browse/SB-28
>      Project: Sandbox
>         Type: Improvement

>   Components: Standalone Tiles
>  Environment: All
>     Reporter: Antonio Petrelli
>     Priority: Minor
>  Attachments: tiles-patch.zip
>
> In this issue, I will post a patch that:
> - changes the way DefinitionsFactory is defined, i.e. it now uses TilesContext instead of Locale;
> - changes to TilesContextFactory, that now is a (potentially configurable) normal class instead of a class with static methods.
> - contains the patches described in:
> http://issues.apache.org/struts/browse/SB-24
> http://issues.apache.org/struts/browse/SB-26
> http://issues.apache.org/struts/browse/SB-27

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (SB-28) Changes to enable DefinitionsFactory customization

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/SB-28?page=all ]

Antonio Petrelli resolved SB-28.
--------------------------------

    Fix Version/s: 2.0
       Resolution: Fixed

Patch applied with a small change, just a problem about the change of "controller" name into "preparer"

> Changes to enable DefinitionsFactory customization
> --------------------------------------------------
>
>                 Key: SB-28
>                 URL: http://issues.apache.org/struts/browse/SB-28
>             Project: Sandbox
>          Issue Type: Improvement
>          Components: Tiles
>         Environment: All
>            Reporter: Antonio Petrelli
>         Assigned To: Antonio Petrelli
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: tiles-patch-2006_09_11.zip, tiles-patch.zip
>
>
> In this issue, I will post a patch that:
> - changes the way DefinitionsFactory is defined, i.e. it now uses TilesContext instead of Locale;
> - changes to TilesContextFactory, that now is a (potentially configurable) normal class instead of a class with static methods.
> - contains the patches described in:
> http://issues.apache.org/struts/browse/SB-24
> http://issues.apache.org/struts/browse/SB-26
> http://issues.apache.org/struts/browse/SB-27

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SB-28) Changes to enable DefinitionsFactory customization

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/SB-28?page=comments#action_38161 ] 
            
Antonio Petrelli commented on SB-28:
------------------------------------

The posted patch needs an update, because some issues have been fixed.
The updated patch should also be independent from other issues.
Expect a new patch the next week.

> Changes to enable DefinitionsFactory customization
> --------------------------------------------------
>
>                 Key: SB-28
>                 URL: http://issues.apache.org/struts/browse/SB-28
>             Project: Sandbox
>          Issue Type: Improvement
>          Components: Tiles
>         Environment: All
>            Reporter: Antonio Petrelli
>            Priority: Minor
>         Attachments: tiles-patch.zip
>
>
> In this issue, I will post a patch that:
> - changes the way DefinitionsFactory is defined, i.e. it now uses TilesContext instead of Locale;
> - changes to TilesContextFactory, that now is a (potentially configurable) normal class instead of a class with static methods.
> - contains the patches described in:
> http://issues.apache.org/struts/browse/SB-24
> http://issues.apache.org/struts/browse/SB-26
> http://issues.apache.org/struts/browse/SB-27

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira