You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Apache Pulsar Slack <ap...@gmail.com> on 2019/11/03 09:11:02 UTC

Slack digest for #dev - 2019-11-03

2019-11-02 23:32:47 UTC - Ali Ahmed: the test assertion retry logic never worked
```
try {
                    assertEquals(sourceStatus.getNumInstances(), 1);
                    assertEquals(sourceStatus.getNumRunning(), 1);
                    assertEquals(sourceStatus.getInstances().size(), 1);
                    assertEquals(sourceStatus.getInstances().get(0).getInstanceId(), 0);
                    assertEquals(sourceStatus.getInstances().get(0).getStatus().isRunning(), true);
                    assertTrue(sourceStatus.getInstances().get(0).getStatus().getLastReceivedTime() &gt; 0);
                    assertEquals(sourceStatus.getInstances().get(0).getStatus().getNumReceivedFromSource(), numMessages);
                    assertEquals(sourceStatus.getInstances().get(0).getStatus().getNumWritten(), numMessages);
                    assertEquals(sourceStatus.getInstances().get(0).getStatus().getNumRestarts(), 0);
                    assertEquals(sourceStatus.getInstances().get(0).getStatus().getLatestSystemExceptions().size(), 0);
                    return;
                } catch (Exception e) {
                    // noop
                }
```
assert statements throw Throwable object not an exception I have fixed the retry logic here
<https://github.com/apache/pulsar/pull/5544>
----