You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/20 07:11:36 UTC
[GitHub] [doris] yiguolei commented on a diff in pull request #10259: [enhancement] optmize 2 cases in seg_iter: all/none rows passed predicate
yiguolei commented on code in PR #10259:
URL: https://github.com/apache/doris/pull/10259#discussion_r901324735
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -859,40 +859,50 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32
void SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_idx,
uint16_t& selected_size) {
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
- if (!_is_need_vec_eval) {
Review Comment:
If _pre_eval_block_predicate is empty, the original code is faster. Because it does not need init ret_flags and call memset to init it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org