You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/16 05:33:11 UTC
[GitHub] [ignite-python-thin-client] ivandasch opened a new pull request #34: IGNITE-14564 Add LICENSE and NOTICE files to all artifacts.
ivandasch opened a new pull request #34:
URL: https://github.com/apache/ignite-python-thin-client/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-python-thin-client] ivandasch commented on a change in pull request #34: IGNITE-14564 Add LICENSE and NOTICE files to all artifacts.
Posted by GitBox <gi...@apache.org>.
ivandasch commented on a change in pull request #34:
URL: https://github.com/apache/ignite-python-thin-client/pull/34#discussion_r614666782
##########
File path: MANIFEST.in
##########
@@ -1,2 +1,13 @@
-recursive-include requirements *
+graft requirements
+graft examples
+graft docs
+recursive-exclude docs/generated *
+graft tests
Review comment:
https://www.apache.org/legal/release-policy.html#source-packages
```
SOURCE PACKAGES
Every ASF release MUST contain one or more source packages, which MUST be sufficient for a user to build and test the release provided they have access to the appropriate platform and tools. A source release SHOULD not contain compiled code.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-python-thin-client] isapego commented on a change in pull request #34: IGNITE-14564 Add LICENSE and NOTICE files to all artifacts.
Posted by GitBox <gi...@apache.org>.
isapego commented on a change in pull request #34:
URL: https://github.com/apache/ignite-python-thin-client/pull/34#discussion_r614661438
##########
File path: MANIFEST.in
##########
@@ -1,2 +1,13 @@
-recursive-include requirements *
+graft requirements
+graft examples
+graft docs
+recursive-exclude docs/generated *
+graft tests
Review comment:
Why do we want tests in package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-python-thin-client] isapego commented on a change in pull request #34: IGNITE-14564 Add LICENSE and NOTICE files to all artifacts.
Posted by GitBox <gi...@apache.org>.
isapego commented on a change in pull request #34:
URL: https://github.com/apache/ignite-python-thin-client/pull/34#discussion_r614667638
##########
File path: MANIFEST.in
##########
@@ -1,2 +1,13 @@
-recursive-include requirements *
+graft requirements
+graft examples
+graft docs
+recursive-exclude docs/generated *
+graft tests
Review comment:
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-python-thin-client] asfgit closed pull request #34: IGNITE-14564 Add LICENSE and NOTICE files to all artifacts.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #34:
URL: https://github.com/apache/ignite-python-thin-client/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org