You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by ad...@apache.org on 2026/04/02 14:54:39 UTC

(fineract) branch develop updated (1460e8a8d6 -> 015851154f)

This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


    from 1460e8a8d6 Merge pull request #5705
     add c9dec5ea92 FINERACT-2421: Refractor String literals (phase 11)
     new 015851154f Merge pull request #5708

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../fineract/commands/domain/CommandWrapper.java   |   70 +-
 .../commands/domain/CommandWrapperConstants.java   |  263 +++
 .../commands/service/CommandWrapperBuilder.java    | 1880 +++++++++++---------
 .../AssetExternalizationStepDef.java               |   76 +-
 .../test/stepdef/common/BatchApiStepDef.java       |   59 +-
 .../ProgressiveLoanTransactionValidatorImpl.java   |  115 +-
 .../hooks/processor/TwilioHookProcessor.java       |    6 +-
 .../AccountNumberPreferencesTestBuilder.java       |   29 +-
 8 files changed, 1503 insertions(+), 995 deletions(-)
 create mode 100644 fineract-core/src/main/java/org/apache/fineract/commands/domain/CommandWrapperConstants.java


(fineract) 01/01: Merge pull request #5708

Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit 015851154f231049b68f7b1cdf9e325e397b981f
Merge: 1460e8a8d6 c9dec5ea92
Author: Adam Saghy <ad...@gmail.com>
AuthorDate: Thu Apr 2 14:54:33 2026 +0000

    Merge pull request #5708
    
    FINERACT-2421: Refractor String literals (phase 11)

 .../fineract/commands/domain/CommandWrapper.java   |   70 +-
 .../commands/domain/CommandWrapperConstants.java   |  263 +++
 .../commands/service/CommandWrapperBuilder.java    | 1880 +++++++++++---------
 .../AssetExternalizationStepDef.java               |   76 +-
 .../test/stepdef/common/BatchApiStepDef.java       |   59 +-
 .../ProgressiveLoanTransactionValidatorImpl.java   |  115 +-
 .../hooks/processor/TwilioHookProcessor.java       |    6 +-
 .../AccountNumberPreferencesTestBuilder.java       |   29 +-
 8 files changed, 1503 insertions(+), 995 deletions(-)

diff --cc fineract-core/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java
index 19ab88d2b4,81e0114353..f4e58cb9a5
--- a/fineract-core/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java
+++ b/fineract-core/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java
@@@ -540,33 -766,9 +766,33 @@@ public class CommandWrapperBuilder 
          return this;
      }
  
 +    public CommandWrapperBuilder createWorkingCapitalBreach() {
 +        this.actionName = "CREATE";
 +        this.entityName = "WORKINGCAPITALBREACH";
 +        this.entityId = null;
 +        this.href = "/working-capital-breach/breaches";
 +        return this;
 +    }
 +
 +    public CommandWrapperBuilder updateWorkingCapitalBreach(final Long breachId) {
 +        this.actionName = "UPDATE";
 +        this.entityName = "WORKINGCAPITALBREACH";
 +        this.entityId = breachId;
 +        this.href = "/working-capital-breach/breaches/" + breachId;
 +        return this;
 +    }
 +
 +    public CommandWrapperBuilder deleteWorkingCapitalBreach(final Long breachId) {
 +        this.actionName = "DELETE";
 +        this.entityName = "WORKINGCAPITALBREACH";
 +        this.entityId = breachId;
 +        this.href = "/working-capital-breach/breaches/" + breachId;
 +        return this;
 +    }
 +
      public CommandWrapperBuilder createWorkingCapitalLoanApplication() {
-         this.actionName = "CREATE";
-         this.entityName = "WORKINGCAPITALLOAN";
+         this.actionName = ACTION_CREATE;
+         this.entityName = ENTITY_WORKINGCAPITALLOAN;
          this.entityId = null;
          this.loanId = null;
          this.href = "/workingcapitalloans";
@@@ -629,26 -831,9 +855,26 @@@
          return this;
      }
  
 +    public CommandWrapperBuilder createWorkingCapitalLoanDelinquencyAction(final Long workingCapitalLoanId) {
 +        this.actionName = "CREATE";
 +        this.entityName = "WC_DELINQUENCY_ACTION";
 +        this.entityId = workingCapitalLoanId;
 +        this.loanId = workingCapitalLoanId;
 +        this.href = "/working-capital-loans/" + workingCapitalLoanId + "/delinquency-actions";
 +        return this;
 +    }
 +
 +    public CommandWrapperBuilder updateDiscountWorkingCapitalLoanApplication(final Long loanId) {
 +        this.actionName = "UPDATEDISCOUNT";
 +        this.entityName = "WORKINGCAPITALLOAN";
 +        this.entityId = loanId;
 +        this.href = "/workingcapitalloans/" + loanId;
 +        return this;
 +    }
 +
      public CommandWrapperBuilder createClientIdentifier(final Long clientId) {
-         this.actionName = "CREATE";
-         this.entityName = "CLIENTIDENTIFIER";
+         this.actionName = ACTION_CREATE;
+         this.entityName = ENTITY_CLIENTIDENTIFIER;
          this.entityId = null;
          this.clientId = clientId;
          this.href = "/clients/" + clientId + "/identifiers/template";
@@@ -2392,20 -2577,9 +2618,20 @@@
          return this;
      }
  
 +    public CommandWrapperBuilder undoFixedDepositAccountTransaction(final Long accountId, final Long transactionId) {
 +        this.actionName = "UNDOTRANSACTION";
 +        this.entityName = "FIXEDDEPOSITACCOUNT";
 +        this.savingsId = accountId;
 +        this.entityId = accountId;
 +        this.subentityId = transactionId;
 +        this.transactionId = transactionId.toString();
 +        this.href = "/fixeddepositaccounts/" + accountId + "/transactions/" + transactionId + "?command=undo";
 +        return this;
 +    }
 +
      public CommandWrapperBuilder fixedDepositAccountActivation(final Long accountId) {
-         this.actionName = "ACTIVATE";
-         this.entityName = "FIXEDDEPOSITACCOUNT";
+         this.actionName = ACTION_ACTIVATE;
+         this.entityName = ENTITY_FIXEDDEPOSITACCOUNT;
          this.savingsId = accountId;
          this.entityId = accountId;
          this.href = "/fixeddepositaccounts/" + accountId + "?command=activate";